-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: ESM documentation consolidation and reordering #36046
Conversation
Review requested:
|
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. While we're at it, I wouldn't mind a switch from builtin
to built-in
but that may be a "tabs vs. spaces" kind of discussion, so I'm OK with this as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this!
I know we were nearly ready to go on this, but I just took a look today and ended up putting a little more time into reworking the differences section. See c4258d2 for the latest commit. The gist of the new changes are the last bullet points in the description of this issue:
|
@devsnek I've posted an update to remove the example, and mentioned |
With the new link to |
Co-authored-by: Rich Trott <rtrott@gmail.com>
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Landed in 187ce5b. |
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
PR-URL: #36046 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
This PR removed the [very helpful] example for how to reproduce the |
@broofa all the examples intentionally use the |
I just went through the
esm.md
docs and consolidated sections where it seemed to make sense as well as reordering the structure slightly now that the layout of this page is finally stable.Changes include:
> Stability
note.file:
,data:
andnode:
URLs. Brought all the file resolution considerations under the "file:
Imports" heading here.pathToFileURL
/
or//
import.meta
intoimport.meta.url
andimport.meta.resolve
subsections. Expanded on their use cases.import()
expressions sectionrequire
of ES modules is not supported because ES modules are asynchronous.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes