-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14.x] doc: drop import.meta.resolve parent arg URL type #38585
[v14.x] doc: drop import.meta.resolve parent arg URL type #38585
Conversation
Thanks for sending this PR! Alternatively I've opened #38587 to add support for |
Sounds great. That'd be handy for me. Thanks @aduh95! |
PR-URL: nodejs#38587 Refs: nodejs#38585 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#38587 Refs: nodejs#38585 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
4ebb88f have landed on master and should be included in the next v16.x release and backported to v14.x You could repurpose this PR to fix the v14.x documentation, which could land in the next v14.x patch release schedule in June. Of course it's totally OK if you're not interested in working on this, someone else can pick it up – or it could simply wait for the August release. |
2614203
to
d8987a6
Compare
Thanks @aduh95, great work! I've retargeted for Good catch about the v12.x docs. Would it make sense for me to create a v12.x backport PR for |
I copied the info from here: Lines 225 to 232 in 0996eb7
When looking at the changelogs, it is also listed in the v12.16.2 release: node/doc/changelogs/CHANGELOG_V12.md Line 2332 in 0996eb7
I find it very surprising you are seeing it available before v12.16.2, are you sure it's not added by some kind of extension?
This section of the docs was part of a larger refactor of the docs in #36046, it hasn't been backported to v12.x yet because so far no one took the time to do it I believe. If you want to open a backport PR that'd be awesome but it's also OK to leave it as is. |
Support for parent argument of type `URL` was added in nodejs#38587, which has not been backported to previous releases yet. Update docs for v14.x to remove the URL type for this argument. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
d8987a6
to
30f1408
Compare
Thanks for investigating the ChangeLog details. I don't know what I was thinking last night. 12.16.2 looks correct to me (both from the commit log and re-testing each 12.16 patch release with NVM). Sorry for the hassle! PR updated. Thanks for the explanation about the v12.x docs! Good call. I'll probably leave that as is. |
Support for parent argument of type `URL` was added in #38587, which has not been backported to previous releases yet. Update docs for v14.x to remove the URL type for this argument. Signed-off-by: Kevin Locke <kevin@kevinlocke.name> PR-URL: #38585 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Landed in 43f4668 |
Support for parent argument of type `URL` was added in #38587, which has not been backported to previous releases yet. Update docs for v14.x to remove the URL type for this argument. Signed-off-by: Kevin Locke <kevin@kevinlocke.name> PR-URL: #38585 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Support for parent argument of type `URL` was added in #38587, which has not been backported to previous releases yet. Update docs for v14.x to remove the URL type for this argument. Signed-off-by: Kevin Locke <kevin@kevinlocke.name> PR-URL: #38585 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Support for parent argument of type `URL` was added in #38587, which has not been backported to previous releases yet. Update docs for v14.x to remove the URL type for this argument. Signed-off-by: Kevin Locke <kevin@kevinlocke.name> PR-URL: #38585 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
I could not find any version of Node.js which accepts a parent argument of type
URL
. For example, on Node.js 16.1.0,index.mjs
with content:produces:
Therefore, update the docs to drop the URL type for this argument.
Thanks for considering,
Kevin
cc: @guybedford, since you are the author of these docs and an expert in all things import.