test: reduce buffer size in buffer-creation test #11177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefourtheye
force-pushed
the
reduce-buffer-creation-size
branch
from
a8587fb
to
f9be6b8
Compare
jasnell
approved these changes
Feb 6, 2017
|
@misterdjules Can this land now? |
misterdjules
suggested changes
Mar 2, 2017
There was a problem hiding this comment.
The code changes look fine to me, but I find the commit message to be a bit confusing for two reasons:
-
this test still allocates "a huge chunk of memory"
-
the commit messages hints that it fixes the test on SmartOS, but we don't have the data to back this up
Can we rephrase the commit message as following:
"This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes test/sequential/test-buffer-creation-regression.js less likely to time out on SmartOS."
|
@thefourtheye Sorry for the delay, I was on vacation until today. |
This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes this test less likely to time out on SmartOS. Ref: nodejs#10166
thefourtheye
force-pushed
the
reduce-buffer-creation-size
branch
from
f9be6b8
to
dbe17a3
Compare
|
@misterdjules No problem :-) Hope you had a good time. Your suggestion looks better than the current commit message so I updated the commit. PTAL. |
cjihrig
approved these changes
Mar 3, 2017
misterdjules
approved these changes
Mar 3, 2017
|
@thefourtheye Thank you for updating the commit message, it is very much appreciated! |
|
CI Run before landing: https://ci.nodejs.org/job/node-test-pull-request/7159/ |
|
Landed in d51f4f3 |
thefourtheye
added a commit
that referenced
this pull request
Apr 4, 2017
This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes this test less likely to time out on SmartOS. PR-URL: #11177 Ref: #10166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes this test less likely to time out on SmartOS. PR-URL: nodejs#11177 Ref: nodejs#10166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes this test less likely to time out on SmartOS. PR-URL: #11177 Ref: #10166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes this test less likely to time out on SmartOS. PR-URL: #11177 Ref: #10166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes this test less likely to time out on SmartOS. PR-URL: nodejs/node#11177 Ref: nodejs/node#10166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the test test/sequential/test-buffer-creation-regression.js fails
in SmartOS, it would be better not to allocate a huge chunk of memory.
Ref: #10166
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test