test: skip when openssl CLI doesn't exist

[sotayamashita]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test

I fixed #9509.

[sam-github]

commit message is ungrammatical, change to

test: check openssl-cli exists

or

test: skip when openssl CLI doesn't exist

[sotayamashita]

@sam-github I changed the commit message

[hiroppy]

CI: https://ci.nodejs.org/job/node-test-pull-request/6156/

[sotayamashita]

@abouthiroppy
I would appreciate if you could tell me how to pass the CI.
When I create a PR, should I run the CI ?

[hiroppy]

@sotayamashita I think these failures are not caused by code🙃 CC @nodejs/testing

[gibfahn]

@sotayamashita those look like infrastructure problems.

CI 2: https://ci.nodejs.org/job/node-test-commit/7616/

[sotayamashita]

@gibfahn Thanks.

[sotayamashita]

@sam-github I changed the commit message. Is it ok ?

[joaocgreis]

Aborted CI, only arm-fanned was pending because of nodejs/build#611

[mhdawson]

LGTM

[mhdawson]

One more attempt at CI run: https://ci.nodejs.org/job/node-test-pull-request/6205/

requested changes have been made

[addaleax]

One more CI attempt: https://ci.nodejs.org/job/node-test-commit/7674/

[jasnell]

New CI since there's some red in that last run: https://ci.nodejs.org/job/node-test-pull-request/6273/

[gibfahn]

@sotayamashita

When I create a PR, should I run the CI ?

Sorry, didn't see this before. Only collaborators have the access to run jobs in the Jenkins CI (ci.nodejs.org). Someone should run the CI for you when you submit the PR, if they don't you can comment asking for it to be run.

As long as you've followed CONTRIBUTING.md and run make -j4 test before submitting, that should be all you need to do.

Once CI has been run, you can click on the link and see the results, if there are any failures that seem related to changes you made you can investigate (but they could also just be infrastructure issues).

In general if you're not sure about something, you can always ask.

[jasnell]

New CI: https://ci.nodejs.org/job/node-test-pull-request/6360/

[sam-github]

Landed in 5ffb7d7

[jasnell]

needs a backport PR to land on v4 or v6

[sotayamashita]

@jasnell I would like to implement but I don not know hot to do it. Is there document ?

[jasnell]

The process is fairly simple. To backport for v6, for instance, create a working branch off the v6-x-staging branch:

$ git checkout v6.x-staging
$ git checkout -b test-openssl-cli-v6-backport

Then cherry-pick the commit that landed in master

$ git cherry-pick 5ffb7d72bb6d8c827b66a337c3318e3ac9b3055e

You will see that there are a number of conflicts to be resolved. Make the necessary changes to fix those conflicts, then complete the cherry-pick using:

$ git add {the-files-that-were-changed}
$ git cherry-pick --continue

Push the branch to your fork on Github and open a new PR against v6.x-staging, indicating that this is a Backport of #11095.

Make sure to run make test and make lint.

[sotayamashita]

@jasnell Thank you very much. I really appreciate your thoughtfulness.