Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-icu-data-dir and test-fs-readdir-ucs2 failing on master #13986

Closed
joaocgreis opened this issue Jun 29, 2017 · 3 comments
Closed

test-icu-data-dir and test-fs-readdir-ucs2 failing on master #13986

joaocgreis opened this issue Jun 29, 2017 · 3 comments
Labels
arm Issues and PRs related to the ARM platform. fs Issues and PRs related to the fs subsystem / file system. i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@joaocgreis
Copy link
Member

  • Version: master
  • Platform: Windows and ARM
  • Subsystem: test

The last node-daily-master job https://ci.nodejs.org/job/node-test-commit/10810/ failed because of two tests. These failures appear to happen on every run of the surrounding runs of the relevant jobs, suggesting the failures are real.

  • parallel/test-icu-data-dir fails on Windows
  • parallel/test-fs-readdir-ucs2 fails on Raspberry Pis (arm-fanned)
@joaocgreis joaocgreis added the test Issues and PRs related to the tests. label Jun 29, 2017
@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. i18n-api Issues and PRs related to the i18n implementation. arm Issues and PRs related to the ARM platform. windows Issues and PRs related to the Windows platform. labels Jun 29, 2017
@tniessen
Copy link
Member

tniessen commented Jun 29, 2017 •
edited
Loading

9330835 appears to cause the problem in test-icu-data-dir. If I revert the change to test-icu-data-dir.js, the test passes. Should be \r\n on Windows.

This was referenced Jun 29, 2017
Closed
Closed
@joaocgreis
Copy link
Member Author

joaocgreis commented Jun 29, 2017 •
edited
Loading

The parallel/test-fs-readdir-ucs2 failure is explained in nodejs/build#774 (comment) . PR to mark as flaky: #13989

@joaocgreis joaocgreis mentioned this issue Jun 29, 2017
Closed
2 tasks
addaleax pushed a commit that referenced this issue Jun 29, 2017
@tniessen @addaleax
test: fix failure in test-icu-data-dir.js
e7ff3b9 
This fixes a broken test on Windows caused by EOL conversion.

PR-URL: #13987
Refs: #13940
Refs: #13986
Reviewed-By: Refael Ackermann <refack@gmail.com>
@tniessen tniessen mentioned this issue Jun 30, 2017
Merged
3 tasks
@joaocgreis
Copy link
Member Author

This can be closed now, issues are no longer blocking CI.

addaleax pushed a commit that referenced this issue Jul 11, 2017
@tniessen @addaleax
test: fix failure in test-icu-data-dir.js
6289b11 
This fixes a broken test on Windows caused by EOL conversion.

PR-URL: #13987
Refs: #13940
Refs: #13986
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit that referenced this issue Jul 18, 2017
@tniessen @addaleax
test: fix failure in test-icu-data-dir.js
fa9e647 
This fixes a broken test on Windows caused by EOL conversion.

PR-URL: #13987
Refs: #13940
Refs: #13986
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. fs Issues and PRs related to the fs subsystem / file system. i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @joaocgreis @tniessen