-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix failure in test-icu-data-dir.js #13987
Conversation
PR broke tests on Windows. Ref: nodejs#13940
Can you use the default revert commit message? It should look something like |
Wouldn't it be better to just fix the tests? |
I will check whether using |
@mscdex PTAL |
As long as it passes CI it's fine by me. |
It appears this already landed in a1ecdcf. |
Landed in a1ecdcf. Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/10072/ @mscdex Yes, I pushed it seconds ago, after going through all the CI failures and making sure they were unrelated. (I just rebased it an hour ago, I didn't land it back then.) |
PR #13940 broke tests on Windows.
Ref: #13986
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
src