Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: ICU 60.1 bump #15540

Closed
srl295 opened this issue Sep 21, 2017 · 8 comments
Closed

deps: ICU 60.1 bump #15540

srl295 opened this issue Sep 21, 2017 · 8 comments
Assignees
@srl295
Labels
i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version. wip Issues and PRs that are still a work in progress.

Comments

@srl295
Copy link
Member

srl295 commented Sep 21, 2017 •
edited
Loading

It’s almost that time again.

Platform: all
Subsystem: deps
RC due 2017-10-04, GA 2017-10-18
backlink: ICU 59 was #12077
depends on: nothing…yet

Semver-minor.

What’s Inside?
@srl295 srl295 added wip Issues and PRs that are still a work in progress. i18n-api Issues and PRs related to the i18n implementation. labels Sep 21, 2017
@srl295 srl295 self-assigned this Sep 21, 2017
@Fishrock123
Copy link
Contributor

Anything notable that this might come with? Why's it semver-minor?

@Fishrock123 Fishrock123 added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 21, 2017
@srl295
Copy link
Member Author

srl295 commented Sep 21, 2017 •
edited
Loading

@Fishrock123 because it should not break any users… I will update the laundry list

We are not even at code freeze yet, about a month away. But I wanted to get this started

@srl295
Copy link
Member Author

srl295 commented Sep 21, 2017 •
edited
Loading

@srl295
Copy link
Member Author

srl295 commented Sep 21, 2017 •
edited
Loading

  • seemed OK… but broken on some platforms

@srl295
Copy link
Member Author

srl295 commented Oct 25, 2017

^ next weather baloon on 68849ba https://ci.nodejs.org/job/node-test-commit/13456

@srl295
Copy link
Member Author

srl295 commented Oct 25, 2017 •
edited
Loading

^ thx @refack , see if https://ci.nodejs.org/job/node-test-commit/13469/ fixes on windows with
09111ef

@srl295
Copy link
Member Author

srl295 commented Oct 31, 2017

OK, ICU GA soon… will open a PR.

@srl295 srl295 mentioned this issue Nov 8, 2017
Closed
2 tasks
@srl295 srl295 closed this as completed in 44d3e17 Nov 10, 2017
evanlucas pushed a commit that referenced this issue Nov 13, 2017
@srl295 @evanlucas
deps: ICU 60 bump
75405a1 
- Update to released ICU 60.1, including:
  - CLDR 32 (many new languages and data improvements)
  - Unicode 10 (8,518 new characters, including four new scripts,
  7,494 new Han characters, and 56 new emoji characters)
  - UTF-8 malformed bytes now handled according to W3C/WHATWG spec

Fixes: #15540
PR-URL: #16876
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@srl295
Copy link
Member Author

srl295 commented Dec 5, 2017 •
edited
Loading

Sorry, had forgotten to update the ICU data on this one (now done), see: nodejs/full-icu-npm#20

gibfahn pushed a commit that referenced this issue Dec 13, 2017
@srl295 @gibfahn
deps: ICU 60 bump
01ddd71 
- Update to released ICU 60.1, including:
  - CLDR 32 (many new languages and data improvements)
  - Unicode 10 (8,518 new characters, including four new scripts,
  7,494 new Han characters, and 56 new emoji characters)
  - UTF-8 malformed bytes now handled according to W3C/WHATWG spec

Fixes: #15540
PR-URL: #16876
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@srl295 srl295 changed the title deps: ICU 60 bump deps: ICU 60.1 bump Dec 14, 2017
MylesBorins pushed a commit that referenced this issue Jan 15, 2018
@srl295 @MylesBorins
deps: ICU 60 bump
ce24581 
- Update to released ICU 60.1, including:
  - CLDR 32 (many new languages and data improvements)
  - Unicode 10 (8,518 new characters, including four new scripts,
  7,494 new Han characters, and 56 new emoji characters)
  - UTF-8 malformed bytes now handled according to W3C/WHATWG spec

Fixes: #15540
PR-URL: #16876
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
srl295 added a commit to srl295/node that referenced this issue Jan 18, 2018
@srl295
deps: ICU 60 bump
a164c9a 
- Update to released ICU 60.1, including:
  - CLDR 32 (many new languages and data improvements)
  - Unicode 10 (8,518 new characters, including four new scripts,
  7,494 new Han characters, and 56 new emoji characters)
  - UTF-8 malformed bytes now handled according to W3C/WHATWG spec

Fixes: nodejs#15540
PR-URL: nodejs#16876
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srl295 @Fishrock123