Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in LICENSE #15261

Closed
wants to merge 1 commit into from
Closed

Fixed a typo in LICENSE #15261

wants to merge 1 commit into from

Conversation

MKRhere
Copy link

@MKRhere MKRhere commented Sep 8, 2017

Line 234: "Copyrighy" instead of "Copyright".

Line 234: "Copyrighy" instead of "Copyright".
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 8, 2017
@richardlau
Copy link
Member

Thanks for submitting. This part of the LICENSE is generated from deps/icu-small/LICENSE by the tools/license-builder.sh script and so will be overwritten the next time the script is run.

@MKRhere
Copy link
Author

MKRhere commented Sep 8, 2017

Thanks for the pointer. I can PR deps/icu-small/LICENSE instead:
#15263

@MKRhere MKRhere mentioned this pull request Sep 8, 2017
@Trott
Copy link
Member

Trott commented Sep 8, 2017

Hi @MKRhere! Welcome and thanks for this! The typo is in a dependency and so that file will also be overwritten the next time we update from the upstream source. The change request should go to the ICU project. You can see the typo in their source tree at http://source.icu-project.org/repos/icu/trunk/icu4c/LICENSE. Their guide on how to contribute to their project is at http://site.icu-project.org/processes/contribute.

@MKRhere
Copy link
Author

MKRhere commented Sep 9, 2017

Added trac issue at ICU. Closing this issue.
Refer #15263

@MKRhere MKRhere closed this Sep 9, 2017
@srl295 srl295 assigned srl295 and unassigned srl295 Sep 13, 2017
@srl295
Copy link
Member

srl295 commented Sep 13, 2017

@MKRhere ok sorry, i saw this go by but didn't see that it was in ICU. No, please do not change deps/small-icu, it is generated as mentioned. The file is actually not sourced from ICU but yet another embedded source. ICU will be making patch though, so in a future ICU this will be fixed. Thanks.

@srl295 srl295 mentioned this pull request Sep 21, 2017
@srl295 srl295 mentioned this pull request Nov 8, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants