Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky stringbytes-external-exceed-max tests on FreeBSD 10-64 #16354

Closed
joyeecheung opened this issue Oct 21, 2017 · 6 comments
Closed

Flaky stringbytes-external-exceed-max tests on FreeBSD 10-64 #16354

joyeecheung opened this issue Oct 21, 2017 · 6 comments
Labels
buffer Issues and PRs related to the buffer subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Oct 21, 2017 •
edited
Loading

  • Version: master
  • Platform: freebsd10-64
  • Subsystem: test

Sample

This is constantly showing up in unrelated PR jobs.

not ok 1807 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max
  ---
  duration_ms: 178.295
  severity: fail
  stack: |-
    timeout
  ...

not ok 1810 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary
  ---
  duration_ms: 127.104
  severity: fail
  stack: |-
    timeout
  ...

not ok 1811 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex
  ---
  duration_ms: 154.918
  severity: fail
  stack: |-
    timeout
@joyeecheung joyeecheung added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 21, 2017
@joyeecheung
Copy link
Member Author

cc @nodejs/testing @nodejs/platform-freebsd

@targos
Copy link
Member

targos commented Oct 21, 2017

These tests started to timeout after the update to V8 6.2. It is most likely because the maximum string size is now 1GB on 64-bit systems.

@targos targos mentioned this issue Oct 21, 2017
Closed
1 task
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Oct 21, 2017
@bnoordhuis
test: mark big string tests flaky on freebsd
ffc04cf 
Some of the addons/stringbytes-external-exceed-max tests are known flaky
after the upgrade to V8 6.2.  The most likely reason is the increase of
the maximum string length from 256 to 1024 MB, pushing their execution
times over the time limit.

Fixes: nodejs#16354
Refs: nodejs#15362
@bnoordhuis bnoordhuis mentioned this issue Oct 21, 2017
Closed
@bnoordhuis
Copy link
Member

#16358

@mscdex mscdex added buffer Issues and PRs related to the buffer subsystem. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests. labels Oct 21, 2017
@Trott
Copy link
Member

Trott commented Oct 22, 2017

A few thoughts on this:

  • Maybe we just need a machine in CI with more RAM or something? (@nodejs/build)

  • I wonder if it's just a matter of tweaking common.enoughTestMem to skip on our FreeBSD 10 host?

  • Perhaps these tests should be moved to pummel?

  • Are removing these tests entirely a reasonable possibility?

@Trott
Copy link
Member

Trott commented Oct 22, 2017

These tests are skipped on machines with less than 1 Gb of RAM. This machine that we're seeing failure on has 1.7-ish Gb of RAM. I'd be cool with moving the threshold up to 1.99 Gb of RAM, so 2Gb or more of RAM runs the test. Not sure how many other machines in CI that might cause the tests to skip on, but honestly, if these tests are only run on one or two platforms in CI, that's probably fine. Thoughts? @nodejs/testing @nodejs/build

Trott added a commit to Trott/io.js that referenced this issue Oct 22, 2017
@Trott
test: increase enoughTestMem to 1.75 Gb
bbea46d 
Fixes: nodejs#16354
@Trott Trott mentioned this issue Oct 22, 2017
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Oct 22, 2017

Increasing common.enoughTestMem to 1.75 Gb seemed like a good idea to me, so: #16374

@Trott Trott closed this as completed in 53f4ac2 Oct 22, 2017
MylesBorins pushed a commit that referenced this issue Oct 23, 2017
@Trott @MylesBorins
test: increase enoughTestMem to 1.75 Gb
3c41f3f 
PR-URL: #16374
Fixes: #16354
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this issue Oct 26, 2017
@Trott @addaleax
test: increase enoughTestMem to 1.75 Gb
37842ac 
PR-URL: nodejs/node#16374
Fixes: nodejs/node#16354
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 16, 2017
@Trott @MylesBorins
test: increase enoughTestMem to 1.75 Gb
b613562 
PR-URL: #16374
Fixes: #16354
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 21, 2017
@Trott @MylesBorins
test: increase enoughTestMem to 1.75 Gb
5eabc57 
PR-URL: #16374
Fixes: #16354
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 28, 2017
@Trott @MylesBorins
test: increase enoughTestMem to 1.75 Gb
62dd6a2 
PR-URL: #16374
Fixes: #16354
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this issue Dec 7, 2017
@Trott @addaleax
test: increase enoughTestMem to 1.75 Gb
224110e 
PR-URL: nodejs/node#16374
Fixes: nodejs/node#16354
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack refack mentioned this issue Aug 13, 2018
Merged
3 tasks
refack added a commit to refack/node that referenced this issue Aug 14, 2018
@refack
test: call gc() explicitly to avoid OOM
4ce744a 
PR-URL: nodejs#22301
Refs: nodejs/reliability#12
Refs: nodejs#16354
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
rvagg pushed a commit that referenced this issue Aug 15, 2018
@refack @rvagg
test: call gc() explicitly to avoid OOM
9feee1f 
PR-URL: #22301
Refs: nodejs/reliability#12
Refs: #16354
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins pushed a commit that referenced this issue Oct 2, 2018
@refack @MylesBorins
test: call gc() explicitly to avoid OOM
d58867a 
PR-URL: #22301
Refs: nodejs/reliability#12
Refs: #16354
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: increase enoughTestMem to 1.75 Gb Trott/io.js
5 participants
@mscdex @bnoordhuis @Trott @targos @joyeecheung