test: increase enoughTestMem to 1.75 Gb #16374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
flaky-test
gireeshpunathil
approved these changes
Oct 22, 2017
joyeecheung
approved these changes
Oct 22, 2017
lpinca
approved these changes
Oct 22, 2017
gibfahn
approved these changes
Oct 22, 2017
|
It didn't skip in FreeBSD 10 on the CI run because it got a Digital Ocean host rather than a Joyent host and our Digital Ocean hosts have slightly more RAM. I've only seen the timeout problem on the Joyent hosts, so I think that works out OK. To check that it does skip the tests on the Joyent FreeBSD 10 hosts and has a green CI there, here's a run there: https://ci.nodejs.org/job/node-test-commit-freebsd/12566/ |
jasnell
approved these changes
Oct 22, 2017
|
Trivial change, easy to revert, fixes CI, 5 approvals, going to expedite... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 22, 2017
PR-URL: nodejs#16374 Fixes: nodejs#16354 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 53f4ac2 |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#16374 Fixes: nodejs/node#16354 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16374 Fixes: nodejs/node#16354 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16354
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)