Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building Node.js on Visual Studio 2019 #27214

Closed
GauthamBanasandra opened this issue Apr 13, 2019 · 3 comments
Closed

Building Node.js on Visual Studio 2019 #27214

GauthamBanasandra opened this issue Apr 13, 2019 · 3 comments
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js. windows Issues and PRs related to the Windows platform.

Comments

@GauthamBanasandra
Copy link
Contributor

GauthamBanasandra commented Apr 13, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Visual Studio 2019 just came out and I tried to build node.js with it. I had a look at the supported toolchains and found that the only toolchain supported for Windows is Visual Studio 2017 - https://github.com/nodejs/node/blob/master/BUILDING.md#windows

Are there any plans to support building Node.js on Visual Studio 2019?

Describe the solution you'd like
Node.js should build successfully on Visual Studio 2019.

Describe alternatives you've considered
N/A
@vsemozhetbyt vsemozhetbyt added build Issues and PRs related to build files or the CI. question Issues that look for answers. windows Issues and PRs related to the Windows platform. labels Apr 13, 2019
@bnoordhuis bnoordhuis added feature request Issues that request new features to be added to Node.js. and removed question Issues that look for answers. labels Apr 13, 2019
@bnoordhuis
Copy link
Member

Are there any plans to support building Node.js on Visual Studio 2019?

Not that I'm aware. The build tool, tools/gyp, needs to be taught to write VS2019-compatible project files. I don't know how much work that entails.

@refack
Copy link
Contributor

refack commented Apr 13, 2019

GYP3 can do that - #26620
There's just one bug that blocks building and it's addressed in #27148

@aduh95 aduh95 mentioned this issue May 3, 2019
Closed
@bnoordhuis bnoordhuis mentioned this issue Jun 20, 2019
Closed
@a7ul a7ul mentioned this issue Jun 21, 2019
Closed
@GauthamBanasandra GauthamBanasandra mentioned this issue Jul 6, 2019
Closed
@gengjiawen
Copy link
Member

Actually current master support this. Just change set target_env=vs2019 in vcbuild.bat.

I am thinking change current strategy. If we can't find vs2017, then we find vs2019 to build instead of a failure message.

cc @nodejs/platform-windows @targos

targos added a commit to targos/node that referenced this issue Oct 18, 2019
@targos
build: default Windows build to Visual Studio 2019
15361bb 
Building and testing Node.js with Visual Studio 2019 is now working as
expected.
Fallback to VS 2017 if VS 2019 was not found.

Fixes: nodejs#27214
@targos targos closed this as completed in b554214 Oct 20, 2019
MylesBorins pushed a commit that referenced this issue Oct 23, 2019
@targos @MylesBorins
build: default Windows build to Visual Studio 2019
24c2982 
Building and testing Node.js with Visual Studio 2019 is now working as
expected.
Fallback to VS 2017 if VS 2019 was not found.

Fixes: #27214

PR-URL: #30022
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
MylesBorins pushed a commit that referenced this issue Oct 23, 2019
@targos @MylesBorins
build: default Windows build to Visual Studio 2019
e04d058 
Building and testing Node.js with Visual Studio 2019 is now working as
expected.
Fallback to VS 2017 if VS 2019 was not found.

Fixes: #27214

PR-URL: #30022
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@refack @bnoordhuis @gengjiawen @GauthamBanasandra @vsemozhetbyt