-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: V8 gyp files fixes #27148
Closed
Closed
build: V8 gyp files fixes #27148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
install
Issues and PRs related to the installers.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
windows
Issues and PRs related to the Windows platform.
labels
Apr 9, 2019
3 tasks
This is to enable better clcache integration
* Turn them into a `none` target
@nodejs/v8-update @nodejs/platform-windows @nodejs/build-files This enables building with MSVS2019 (Currently blocked by a bug), and also improves build time by optimizing PCH usage, and better integration with |
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
May 31, 2020 12:19
8ae28ff
to
2935f72
Compare
There's been no activity on this in over a year and there are conflicts. Closing. Can reopen if someone decides they want to pick it back up. |
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues and PRs related to build files or the CI.
review wanted
PRs that need reviews.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: V8 toolchain.gypi dedup and comment 353fbf3
Mostly semantically neutral refactoring, except for:
https://github.com/nodejs/node/blob/353fbf34bd0c02d1004d4614c1520ded4bee5e99/tools/v8_gypfiles/toolchain.gypi#L1236
which improves debugging experience for the "Debug" build.
build: rename v8 PCH files and add new 1/2 bd299ff, 7cad083
Improves V8 build time
build: include PCH dir when using PCH f7387df
Enables better compilation cache
build: V8 workaround for MSVC 14.20 bug 758f57c
Refs: developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html
build: move tourqe and inspector codegen 5d211e8
Refs: test: flakiness in building addons with
make
#22006A step toward reducing unnecessary recompilation.
/CC @nodejs/build-files @nodejs/platform-windows @nodejs/v8-update
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes