-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fixes and optimizations in gyp files #27108
Conversation
/CC @nodejs/build-files @nodejs/v8-update |
bb39ecf
to
ea42d79
Compare
}, | ||
'include_dirs': ['.', 'include'], | ||
'defines': [ | ||
'GTEST_LANG_CXX11=1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://codereview.chromium.org/2174663002/. Maybe we should be bumping our vendored in version of gtest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have that in the pipe line.
24ac28b
to
0e089b3
Compare
d161800
to
9b0ac8b
Compare
Ping @nodejs/build-files PTAL. |
Ping @nodejs/v8-update |
Can you split this into smaller PRs? I can review some of the GYP changes, but can't really sign off on Windows/MSVC spcific changes. |
9b0ac8b
to
18e465d
Compare
13a110d
to
9b770b3
Compare
node.gyp
Outdated
['OS=="win"', { | ||
'sources': ['src/res/node.rc'], | ||
'conditions': [ | ||
['node_use_etw=="true"', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, doesn't this break etw builds? (I am not sure who actually uses this, though, and it's been broken quite often, but it's listed in https://github.com/nodejs/node/blob/master/doc/guides/diagnostic-tooling-support-tiers.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code just moved to
Line 627 in 380d1a6
[ 'node_use_etw=="true"', { |
* Remove use of `tr1` namespace * Sync file list
63f4c78
to
380d1a6
Compare
@nodejs/build-files PTAL |
8ae28ff
to
2935f72
Compare
No activity on this is over a year, does not appear to be moving forward. Closing, can reopen if someone wishes to pick it back up |
tools/v8_gypfiles
v8_initializers_pch.h
GTEST_LANG_CXX11
for gtest compatibility with C++17 (TR namespace removed)Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes