build,win: rename node.lib to libnode.lib

[refack]

eliminate the need for rename_node_bin_win

P.S. This might be considered semver-major, but IMO only in the context of of @nodejs/delivery-channels

/CC @nodejs/build-files @nodejs/platform-windows

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3210

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22294/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22298/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22309/

[joyeecheung]

LGTM if CI is happy.

[joyeecheung]

I think this would make the product..liblibnode.so/liblibnode.dylib on other platforms? (looks a bit funny, but probably not a big deal)

[refack]

I think this would make the product..liblibnode.so/liblibnode.dylib on other platforms?

This is the line I see on linuxONE for example:

ar crsT /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/out/Release/obj.target/libnode.a ...
                                                                                                       ^^^^^^^^^

[MarshallOfSound]

At first glance this would appear to cause issues on Windows with node-gyp that very specifically links to node.lib.

Do we have any validation that native modules still work against a renamed node binary with this change?

[joyeecheung]

@MarshallOfSound test/addons should cover that, I believe.

[joyeecheung]

I just noticed that we explicitly mentions node.lib in several documentation e.g. it's part of process.release.libUrl

[refack]

Do we have any validation that native modules still work against a renamed node binary with this change?

Each one of our CI jobs builds several native addons (with node-gyp). But it does seem like there's a bug in the CI script...

This will not land until I'm sure that is resolved.

I just noticed that we explicitly mentions node.lib in several documentation e.g. it's part of process.release.libUrl

I'll grep for these.

[refack]

Do we have any validation that native modules still work against a renamed node binary with this change?

Each one of our CI jobs builds several native addons (with node-gyp). But it does seem like there's a bug in the CI script...

This will not land until I'm sure that is resolved.

I just noticed that we explicitly mentions node.lib in several documentation e.g. it's part of process.release.libUrl

I'll grep for these.

Ok, so even I got confused. node.lib is an artifact of building the main exe:

     Creating library out\Debug\node.lib and object out\Debug\node.exp
  node.vcxproj -> out\Debug\\node.exe
FinalizeBuildStatus:
  Deleting file "out\Debug\obj\node\node.tlog\unsuccessfulbuild".
  Touching "out\Debug\obj\node\node.tlog\node.lastbuildstate".
Done Building Project "D:\code\node\node.vcxproj" (Build target(s)).

nodelib.lib as a static library is just a partial part of the build, and it could be configured to be a dynamic library in special build configuration.

tl;dr this is not semver major even WRT to downstream embedders.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22361/

[refack]

/CC @nodejs/build-files @nodejs/platform-windows PTAL