Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky parallel/test-tls-passphrase on OS X #28111

Closed
sam-github opened this issue Jun 6, 2019 · 0 comments
Closed

Investigate flaky parallel/test-tls-passphrase on OS X #28111

sam-github opened this issue Jun 6, 2019 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Comments

@sam-github
Copy link
Contributor

test.parallel/test-tls-passphrase failed on an unrelated PR, https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1011/27279/

It's possible its related the race conditions in tests that are being exposed by TLS1.3 packet order being different from TLS1.2, it needs some looking into.

events.js:177
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  errno: 'ECONNRESET',
  code: 'ECONNRESET',
  syscall: 'read'
}
  • Version:
  • Platform:
  • Subsystem:
@sam-github sam-github added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. macos Issues and PRs related to the macOS platform / OSX. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jun 6, 2019
lpinca added a commit to lpinca/node that referenced this issue Aug 15, 2019
Move `socket.end()` to client.

Fixes: nodejs#28111
Refs: nodejs#27569
@Trott Trott closed this as completed in a0cc62f Aug 19, 2019
targos pushed a commit that referenced this issue Aug 20, 2019
Move `socket.end()` to client.

Fixes: #28111
Refs: #27569

PR-URL: #29134
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant