-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: deflake test-tls-passphrase #29134
Conversation
|
cc: @sam-github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion.
20c24fd
to
6db2364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lpinca It looks like you are changing it so client ends connection rather than server, to prevent races. Is it still flaky, or not flaky? I'm not sure if the errors you pinged me about were before or after your fix. The changes LGTM
The error is before fix, it is no longer flaky now unless I raise Also it looks this fixes #28111. Will add the "Fixes:" metadata. |
Move `socket.end()` to client. Fixes: nodejs#28111 Refs: nodejs#27569
6db2364
to
6d6de17
Compare
Landed in a0cc62f |
Move `socket.end()` to client. Fixes: #28111 Refs: #27569 PR-URL: #29134 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Move `socket.end()` to client. Fixes: #28111 Refs: #27569 PR-URL: #29134 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Move
socket.end()
to client.Fixes: #28111
Refs: #27569
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes