Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deflake test-tls-passphrase #29134

Closed
wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Aug 15, 2019

Move socket.end() to client.

Fixes: #28111
Refs: #27569

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 15, 2019
@lpinca
Copy link
Member Author

lpinca commented Aug 15, 2019

$ ./tools/test.py -J --repeat=500 test/parallel/test-tls-passphrase.js 
=== release test-tls-passphrase ===                   
Path: parallel/test-tls-passphrase
events.js:186
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event on TLSSocket instance at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:77:11) {
  errno: -54,
  code: 'ECONNRESET',
  syscall: 'read'
}
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-tls-passphrase.js
=== release test-tls-passphrase ===                   
Path: parallel/test-tls-passphrase
events.js:186
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event on TLSSocket instance at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:77:11) {
  errno: -54,
  code: 'ECONNRESET',
  syscall: 'read'
}
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-tls-passphrase.js

...

@lpinca lpinca added macos Issues and PRs related to the macOS platform / OSX. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Aug 15, 2019
@lpinca
Copy link
Member Author

lpinca commented Aug 15, 2019

cc: @sam-github

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion.

test/parallel/test-tls-passphrase.js Outdated Show resolved Hide resolved
@lpinca lpinca force-pushed the deflake/test-tls-passphrase branch from 20c24fd to 6db2364 Compare August 15, 2019 10:19
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpinca It looks like you are changing it so client ends connection rather than server, to prevent races. Is it still flaky, or not flaky? I'm not sure if the errors you pinged me about were before or after your fix. The changes LGTM

@lpinca
Copy link
Member Author

lpinca commented Aug 15, 2019

The error is before fix, it is no longer flaky now unless I raise --repeat to 1000. After that a new errors occurs (EADDRNOTAVAIL) but that is a different issue. See #28337 (comment).

Also it looks this fixes #28111. Will add the "Fixes:" metadata.

Move `socket.end()` to client.

Fixes: nodejs#28111
Refs: nodejs#27569
@lpinca lpinca force-pushed the deflake/test-tls-passphrase branch from 6db2364 to 6d6de17 Compare August 15, 2019 16:11
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Aug 19, 2019

Landed in a0cc62f

@Trott Trott closed this Aug 19, 2019
Trott pushed a commit that referenced this pull request Aug 19, 2019
Move `socket.end()` to client.

Fixes: #28111
Refs: #27569

PR-URL: #29134
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca lpinca deleted the deflake/test-tls-passphrase branch August 19, 2019 20:00
targos pushed a commit that referenced this pull request Aug 20, 2019
Move `socket.end()` to client.

Fixes: #28111
Refs: #27569

PR-URL: #29134
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky parallel/test-tls-passphrase on OS X
7 participants