Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2/compat: undocumented public property "complete" #28622

Closed
ronag opened this issue Jul 10, 2019 · 0 comments
Closed

http2/compat: undocumented public property "complete" #28622

ronag opened this issue Jul 10, 2019 · 0 comments
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Comments

@ronag
Copy link
Member

ronag commented Jul 10, 2019 •
edited
Loading

The Http2ServerRequest has an undocumented public property "complete".

I guess it should be either be documented or made private? What is it's purpose? Should we add it to http/1?

  get complete() {
    return this._readableState.ended ||
           this[kState].closed ||
           this[kStream].destroyed;
  }

I'm not sure where this property is useful over just checking this[kState].closed? Seems like some kind of hybrid property of streams being closed and the old http/1 finished semantics.

I guess it is true if end() has been called OR 'close' has been emitted?
@lpinca lpinca added http2 Issues or PRs related to the http2 subsystem. doc Issues and PRs related to the documentations. labels Jul 14, 2019
@javleds javleds mentioned this issue Sep 15, 2019
Closed
2 tasks
@Trott Trott closed this as completed in 0a0b2b7 Sep 18, 2019
targos pushed a commit that referenced this issue Sep 20, 2019
@javleds @targos
doc: add missing complete property to http2 docs
07c94e6 
PR-URL: #29571
Fixes: #28622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this issue Sep 25, 2019
@javleds @BridgeAR
doc: add missing complete property to http2 docs
38028ef 
PR-URL: #29571
Fixes: #28622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add missing complete property to request javleds/node
2 participants
@lpinca @ronag