doc: add missing complete property to request #29571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
devnexen
reviewed
Sep 16, 2019
doc/api/http2.md
Outdated
| @@ -2673,6 +2673,16 @@ added: v10.1.0 | |||
| The `request.aborted` property will be `true` if the request has | |||
| been aborted. | |||
|
|
|||
| #### request.complete | |||
There was a problem hiding this comment.
nit: have the feeling it s in alphabetical order isn't it ?
There was a problem hiding this comment.
It wasn't it, but now is fixed.
javleds
force-pushed
the
docs/Http2ServerRequest_complete_property
branch
from
5653fed to
50db6cb
Compare
javleds
force-pushed
the
docs/Http2ServerRequest_complete_property
branch
from
50db6cb to
4a53478
Compare
jasnell
approved these changes
Sep 16, 2019
Trott
reviewed
Sep 18, 2019
doc/api/http2.md
Outdated
| * {boolean} | ||
|
|
||
| The `request.complete` property will be `true` if the request has | ||
| been completed, aborted or destroyed. |
There was a problem hiding this comment.
Suggested change
| been completed, aborted or destroyed. | |
| been completed, aborted, or destroyed. |
Trott
approved these changes
Sep 18, 2019
|
Landed in 0a0b2b7. Thanks for the contribution! 🎉 |
Merged
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: http2/compat: undocumented public property “complete” · Issue #28622 · nodejs/node · GitHub
Checklist