Issues with newer V8 versions

[targos]

See #42115 (comment). I'm opening a new issue for visibility.

Staring with V8 version 9.9 (and still with the latest canary, V8 fails to compile on Windows with MSVC (2019 and 2022).

@bnoordhuis tried to help finding a workaround, but it didn't work.

I opened an issue on V8's tracker (v8:12661). It was assigned a low priority which makes sense from their point of view because MSVC is not officially supported by V8.

@gengjiawen requested access to a Windows VM in nodejs/build#2891 but it's not clear if someone is going to give them this access.

I think this is becoming critical for us. V8 updates are blocked because of this issue and we are coming close to the release of v18.0.0.

@nodejs/tsc @nodejs/platform-windows @nodejs/v8-update @nodejs/v8

[gengjiawen]

I borrow a windows to fix this. But I do hope there is a long term plan for this (accessing windows vm)

[targos]

Update:

• @gengjiawen found a working workaround for the Windows compiler error. Upstream: https://chromium-review.googlesource.com/c/v8/v8/+/3533019
• I updated the PR to directly skip to V8 10.1, as that's the lowest one I would like to include in v18.0.0.
• There's a new issue in debug builds related to snapshot and workers: deps: update V8 to 10.2 #42115 (comment)
• There's another issue on Windows, related to cross-compilation (x86 and arm64): deps: update V8 to 10.2 #42115 (comment)

[niyas-sait]

I had a quick look at the windows/arm64 specific issue due to the upgrade. I can see at least two issues

(1) Native compilation fails with the latest windows SDK (10.0.220000). Looks like a minor issue. I will try to propose a change to V8 to fix it. But older SDK versions should work

(2) Cross-compilation fails for win/arm64. This looks like it due to using pre-compiled headers to build host modules and some conflicts between x64 and arm64 register definitions. I don't understand the code well enough to propose a fix, but looks like disabling pre-compiled header for host toolset might fix it

[targos]

This looks like it due to using pre-compiled headers to build host modules and some conflicts between x64 and arm64 register definitions.

Interesting. Thanks for investigating!