Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 10.1 #42657

Closed
wants to merge 21 commits into from
Closed

deps: update V8 to 10.1 #42657

wants to merge 21 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 8, 2022 •
edited
Loading

If Windows 32 bits CI still fails, I will open another PR to temporarily make that platform experimental, as discussed in this week's TSC meeting.
Edit: failure confirmed: https://ci.nodejs.org/job/node-compile-windows/44578/nodes=win-vs2019-x86/console

@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 8, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 8, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 8, 2022 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/43398/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4619/

@targos
Copy link
Member Author

targos commented Apr 8, 2022

@nodejs/tsc

@aduh95
Copy link
Contributor

aduh95 commented Apr 8, 2022

It looks like the 32-bit Windows build has failed: https://ci.nodejs.org/job/node-compile-windows/44578/nodes=win-vs2019-x86/console

@github-actions github-actions bot mentioned this pull request Apr 9, 2022
Open
24 tasks
@targos
Copy link
Member Author

targos commented Apr 9, 2022 •
edited
Loading

Now I don't understand why test-repl-mode fails everywhere with 10.1. It didn't last week...
I'm wrong. It failed with 10.1 too: https://ci.nodejs.org/job/node-test-pull-request/43341/

@targos
Copy link
Member Author

targos commented Apr 9, 2022

If we look at canary, it failed once on March 25 and was fixed on March 26. Checking the commits that landed on V8 in between...

@targos
Copy link
Member Author

targos commented Apr 9, 2022

Added a cherry-pick of v8/v8@a2cae21

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 9, 2022 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/43404/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4620/

@targos
Copy link
Member Author

targos commented Apr 9, 2022

@nodejs/build assuming #42666 lands, how do we handle x86 Windows in CI?

@targos targos mentioned this pull request Apr 9, 2022
Closed
@github-actions github-actions bot mentioned this pull request Apr 10, 2022
Open
26 tasks
@richardlau richardlau mentioned this pull request Apr 10, 2022
Merged
@richardlau
Copy link
Member

@nodejs/build assuming #42666 lands, how do we handle x86 Windows in CI?

Opened nodejs/build#2921 to not run the Windows x86 builds for Node.js 18 for now.

This was referenced Apr 11, 2022
Open
Open
@joyeecheung
Copy link
Member

FYI https://chromium-review.googlesource.com/c/v8/v8/+/3575468 has landed and it should fix the near heap limit callback issue without a fix in Node.js (I ran a CI with it before and the test passed https://ci.nodejs.org/job/node-test-commit/52817/)

targos and others added 8 commits April 12, 2022 11:10
@targos
deps: update V8 to 10.1.124.6
a5cecb3
@targos
build: reset embedder string to "-node.0"
f4df3c5
@targos
src: update NODE_MODULE_VERSION to 108
9be688c 
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 10.1.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
@refack @targos
deps: V8: un-cherry-pick bd019bd
4f4d0a5 
Original commit message:

    [testrunner] delete ancient junit compatible format support

    Testrunner has ancient support for JUnit compatible XML output.

    This CL removes this old feature.

    R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
    CC=​machenbach@chromium.org

    Bug: v8:8728
    Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1430065
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Tamer Tas <tmrts@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59045}

Refs: v8/v8@bd019bd

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack @targos
deps: V8: forward declaration of Rtl*FunctionTable
1db7e5b 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gengjiawen @targos
deps: fix V8 build issue with inline methods
4451f9e 
PR-URL: nodejs#35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

deps: patch for v8 on windows

PR-URL: nodejs#40010
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs#40060
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

deps: workaround debug link error on Windows

PR-URL: nodejs#38807
Refs: nodejs#38788
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
@targos
deps: disable trap handler for Windows cross-compiler
f5e32e9 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs#40488
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
deps: silence V8's warning on CompileFunction
b253a3a 
We are not ready to migrate yet.

Refs: nodejs/node-v8#214

PR-URL: nodejs#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 9, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
375499b 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 10, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
cdfff76 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 11, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
2335f0e 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 12, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
aefe246 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 13, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
5a7d700 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 14, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
8bf0088 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 15, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
b40cac3 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 16, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
70c68aa 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 17, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
22a0731 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 18, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
4c9b5ff 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 19, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
df202bc 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 20, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
c7805f4 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 21, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
da7283e 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 22, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
3e9d093 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 23, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
cfb78c1 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 24, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
4d6d0ab 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 25, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
a9b8cbe 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 26, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
deb9524 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 27, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
3dabc2d 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 28, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
80157f0 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 29, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
c66df2b 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 30, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
6cfe663 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 31, 2022
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
926846b 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 1, 2023
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
a25999f 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 2, 2023
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
1b21236 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Jan 2, 2023
@gengjiawen @targos
deps: V8: fix v8-cppgc.h for MSVC
574ea0b 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: #42375

PR-URL: #42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 2, 2023
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
4419913 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 3, 2023
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
75df294 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 4, 2023
@gengjiawen @nodejs-github-bot
deps: V8: fix v8-cppgc.h for MSVC
9e671e5 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs/node#42375

PR-URL: nodejs/node#42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @patchup @khalwa
chore: upgrade to Node.js v18 (electron#35999)
b19d67a 
* chore: update to Node.js v18

* child_process: improve argument validation

nodejs/node#41305

* bootstrap: support configure-time user-land snapshot

nodejs/node#42466

* chore: update GN patch

* src: disambiguate terms used to refer to builtins and addons

nodejs/node#44135

* src: use a typed array internally for process._exiting

nodejs/node#43883

* chore: lib/internal/bootstrap -> lib/internal/process

* src: disambiguate terms used to refer to builtins and addons

nodejs/node#44135

* chore: remove redudant browserGlobals patch

* chore: update BoringSSL patch

* src: allow embedder-provided PageAllocator in NodePlatform

nodejs/node#38362

* chore: fixup Node.js crypto tests

- nodejs/node#44171
- nodejs/node#41600

* lib: add Promise methods to avoid-prototype-pollution lint rule

nodejs/node#43849

* deps: update V8 to 10.1

nodejs/node#42657

* src: add kNoBrowserGlobals flag for Environment

nodejs/node#40532

* chore: consolidate asar initialization patches

* deps: update V8 to 10.1

nodejs/node#42657

* deps: update V8 to 9.8

nodejs/node#41610

* src,crypto: remove AllocatedBuffers from crypto_spkac

nodejs/node#40752

* build: enable V8's shared read-only heap

nodejs/node#42809

* src: fix ssize_t error from nghttp2.h

nodejs/node#44393

* chore: fixup ESM patch

* chore: fixup patch indices

* src: merge NativeModuleEnv into NativeModuleLoader

nodejs/node#43824

* [API] Pass OOMDetails to OOMErrorCallback

https://chromium-review.googlesource.com/c/v8/v8/+/3647827

* src: iwyu in cleanup_queue.cc

* src: return Maybe from a couple of functions

nodejs/node#39603

* src: clean up embedder API

nodejs/node#35897

* src: refactor DH groups to delete crypto_groups.h

nodejs/node#43896

* deps,src: use SIMD for normal base64 encoding

nodejs/node#39775

* chore: remove deleted source file

* chore: update patches

* chore: remove deleted source file

* lib: add fetch

nodejs/node#41749

* chore: remove nonexistent node specs

* test: split report OOM tests

nodejs/node#44389

* src: trace fs async api

nodejs/node#44057

* http: trace http request / response

nodejs/node#44102

* test: split test-crypto-dh.js

nodejs/node#40451

* crypto: introduce X509Certificate API

nodejs/node#36804

* src: split property helpers from node::Environment

nodejs/node#44056

* nodejs/node#38905

bootstrap: implement run-time user-land snapshots via --build-snapshot and --snapshot-blob

* lib,src: implement WebAssembly Web API

nodejs/node#42701

* fixup! deps,src: use SIMD for normal base64 encoding

* fixup! src: refactor DH groups to delete crypto_groups.h

* chore: fixup base64 GN file

* fix: check that node::InitializeContext() returns true

* chore: delete _noBrowserGlobals usage

* chore: disable fetch in renderer procceses

* dns: default to verbatim=true in dns.lookup()

nodejs/node#39987

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson left review comments

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

@targos targos

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.