Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test runner v8 serialization fails #48103

Closed
MoLow opened this issue May 21, 2023 · 1 comment · Fixed by #48106
Closed

test runner v8 serialization fails #48103

MoLow opened this issue May 21, 2023 · 1 comment · Fixed by #48106
Assignees
@MoLow
Labels
confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem.

Comments

@MoLow
Copy link
Member

MoLow commented May 21, 2023

Not sure if there is a simple reproduction, but seen this in CI (https://ci.nodejs.org/job/node-test-commit-freebsd/49824/nodes=freebsd12-x64/consoleFull):

13:32:50         # Subtest: test-runner/output/output_cli.js
13:32:50         not ok 14 - test-runner/output/output_cli.js
13:32:50           ---
13:32:50           duration_ms: 12475.461475
13:32:50           failureType: 'testCodeFailure'
13:32:50           error: |-
13:32:50             Expected values to be strictly equal:
13:32:50             + actual - expected ... Lines skipped
13:32:50             
13:32:50               'TAP version 13\n' +
13:32:50                 '# Subtest: sync pass todo\n' +
13:32:50             ...
13:32:50                 '  ...\n' +
13:32:50                 '# Subtest: functionOnly\n' +
13:32:50             +   '# \x00\x00\x00��\x0Fo"\x04type"\\\\ttest:pass"\x04datao"\x04name"\\\\ffunctionOnly"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\n' +
13:32:50             +   '# testNumberI<"\x07detailso"\\\\vduration_msN4�%\x1B\x0F��?{\x01{\x05{\x02\x00\x00\x00��\x0Fo"\x04type"\n' +
13:32:50             +   '# test:start"\x04datao"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\x04name"\\\\v<anonymous>{\x03{\x02\x00\x00\x00��\x0Fo"\x04type"\\\\ttest:pass"\x04datao"\x04name"\\\\v<anonymous>"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\n' +
13:32:50             +   '# testNumberI>"\x07detailso"\\\\vduration_msN��aNв?{\x01{\x05{\x02\x00\x00\x00��\x0Fo"\x04type"\n' +
13:32:50             +   '# test:start"\x04datao"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\x04name"\x1Etest with only a name provided{\x03{\x02\x00\x00\x00��\x0Fo"\x04type"\\\\ttest:pass"\x04datao"\x04name"\x1Etest with only a name provided"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\n' +
13:32:50             +   '# testNumberI@"\x07detailso"\\\\vduration_msN[z4Փ��?{\x01{\x05{\x02\x00\x00\x00��\x0Fo"\x04type"\n' +
13:32:50             +   '# test:start"\x04datao"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\x04name"\\\\v<anonymous>{\x03{\x02\x00\x00\x00��\x0Fo"\x04type"\\\\ttest:pass"\x04datao"\x04name"\\\\v<anonymous>"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\n' +
13:32:50             +   '# testNumberIB"\x07detailso"\\\\vduration_msN��J\x05\x15�?{\x01{\x05{\x02\x00\x00\x00��\x0Fo"\x04type"\n' +
13:32:50             +   '# test:start"\x04datao"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\x04name"\\\\v<anonymous>{\x03{\x02\x00\x00\x00��\x0Fo"\x04type"\\\\ttest:pass"\x04datao"\x04name"\\\\v<anonymous>"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\n' +
13:32:50             +   '# testNumberID"\x07detailso"\\\\vduration_msN���Z�{�?{\x01"\x04skipT{\x06{\x02\x00\x00\x00��\x0Fo"\x04type"\n' +
13:32:50             +   '# test:start"\x04datao"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\x04name"%test with a name and options provided{\x03{\x02\x00\x00\x01\\\\f�\x0Fo"\x04type"\\\\ttest:pass"\x04datao"\x04name"%test with a name and options provided"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\n' +
13:32:50             +   '# testNumberIF"\x07detailso"\\\\vduration_msN�OU��X�?{\x01"\x04skipT{\x06{\x02\x00\x00\x00��\x0Fo"\x04type"\n' +
13:32:50             +   '# test:start"\x04datao"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\x04name"\x12functionAndOptions{\x03{\x02\x00\x00\x00��\x0Fo"\x04type"\\\\ttest:pass"\x04datao"\x04name"\x12functionAndOptions"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\n' +
13:32:50             +   '# testNumberIH"\x07detailso"\\\\vduration_msN�K���H�?{\x01"\x04skipT{\x06{\x02\x00\x00\x00��\x0Fo"\x04type"\n' +
13:32:50             +   `# test:start"\x04datao"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\x04name"'escaped description \\\\ \\# \\\\\\#\\\\ \n` +
13:32:50             +   `#  \\\\t \\\\f \\\\v \\\\b \\\\r{\x03{\x02\x00\x00\x01\x07�\x0Fo"\x04type"\\\\ttest:pass"\x04datao"\x04name"'escaped description \\\\ \\# \\\\\\#\\\\ \n` +
13:32:50             +   '#  \\\\t \\\\f \\\\v \\\\b \\\\r"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\n' +
13:32:50             +   '# testNumberIJ"\x07detailso"\\\\vduration_msN즔�J�?{\x01{\x05{\x02\x00\x00\x00��\x0Fo"\x04type"\n' +
13:32:50             +   '# test:start"\x04datao"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\x04name"\x14escaped skip message{\x03{\x02\x00\x00\x01\x01�\x0Fo"\x04type"\\\\ttest:pass"\x04datao"\x04name"\x14escaped skip message"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\n' +
13:32:50             +   '# testNumberIL"\x07detailso"\\\\vduration_msNq�����?{\x01"\x04skip"\x05\\#skip{\x06{\x02\x00\x00\x00��\x0Fo"\x04type"\n' +
13:32:50             +   '# test:start"\x04datao"\x07nestingI\x00"\x04file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"\x04name"\x14escaped '... 11980 more characters

at some point stdout fails to deserialize:

13:32:50             # Subtest: <anonymous>
13:32:50             ok 29 - <anonymous>
13:32:50               ---
13:32:50               duration_ms: *
13:32:50               ...
13:32:50             # Subtest: functionOnly
13:32:50             # ���o"�type"\\ttest:pass"�datao"�name"\\ffunctionOnly"�nestingI"�file"v/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/fixtures/test-runner/output/output.js"
@MoLow MoLow added confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem. labels May 21, 2023
@MoLow
Copy link
Member Author

MoLow commented May 21, 2023

it seems like the header starting each message is being split in between two chunks on stdout.

@MoLow MoLow self-assigned this May 21, 2023
@MoLow MoLow mentioned this issue May 21, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue May 23, 2023
@MoLow
test_runner: fix test deserialize edge cases
f0e70ee 
PR-URL: #48106
Fixes: #48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this issue May 30, 2023
@MoLow @targos
test_runner: fix test deserialize edge cases
027c531 
PR-URL: #48106
Fixes: #48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this issue Jul 6, 2023
@MoLow @danielleadams
test_runner: fix test deserialize edge cases
d18b61b 
PR-URL: #48106
Fixes: #48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Jul 6, 2023
@MoLow
test_runner: fix test deserialize edge cases
47602fe 
PR-URL: nodejs#48106
Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@MoLow @Ceres6
test_runner: fix test deserialize edge cases
697b6bd 
PR-URL: nodejs#48106
Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@MoLow @Ceres6
test_runner: fix test deserialize edge cases
84b2e49 
PR-URL: nodejs#48106
Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MoLow MoLow

Labels
confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test_runner: fix test deserialize edge cases MoLow/node
1 participant
@MoLow