Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix test deserialize edge cases #48106

Merged
merged 1 commit into from
May 23, 2023
Merged

test_runner: fix test deserialize edge cases #48106

merged 1 commit into from
May 23, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented May 21, 2023

Fixes: #48103

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 21, 2023
@MoLow MoLow requested a review from cjihrig May 22, 2023 15:51
cjihrig
cjihrig approved these changes May 22, 2023
View reviewed changes
lib/internal/test_runner/runner.js Outdated Show resolved Hide resolved
test/parallel/test-runner-v8-deserializer.mjs Outdated Show resolved Hide resolved
test/parallel/test-runner-v8-deserializer.mjs Outdated Show resolved Hide resolved
test/parallel/test-runner-v8-deserializer.mjs Outdated Show resolved Hide resolved
test/parallel/test-runner-v8-deserializer.mjs Outdated Show resolved Hide resolved
test/parallel/test-runner-v8-deserializer.mjs Outdated Show resolved Hide resolved
lib/internal/test_runner/runner.js Outdated Show resolved Hide resolved
lib/internal/test_runner/runner.js Outdated Show resolved Hide resolved
@cjihrig
Copy link
Contributor

cjihrig commented May 22, 2023

It might be worth adding a note/label on the original PR that moved to V8 serialization that this PR should be backported with it.

@MoLow MoLow force-pushed the fix-test-deserialize branch from 1b32632 to e669180 Compare May 23, 2023 05:52
@MoLow MoLow mentioned this pull request May 23, 2023
Merged
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51921/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51923/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51924/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51938/

@MoLow MoLow requested a review from benjamingr May 23, 2023 17:01
@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2023
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit f0e70ee into nodejs:main May 23, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f0e70ee

@MoLow MoLow deleted the fix-test-deserialize branch May 23, 2023 21:03
This was referenced May 24, 2023
Open
Open
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
@MoLow @targos
test_runner: fix test deserialize edge cases
027c531 
PR-URL: #48106
Fixes: #48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@github-actions github-actions bot mentioned this pull request May 31, 2023
Open
22 tasks
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
test_runner: fix test deserialize edge cases
d18b61b 
PR-URL: #48106
Fixes: #48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test_runner: fix test deserialize edge cases
47602fe 
PR-URL: nodejs#48106
Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: fix test deserialize edge cases
697b6bd 
PR-URL: nodejs#48106
Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: fix test deserialize edge cases
84b2e49 
PR-URL: nodejs#48106
Fixes: nodejs#48103
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test runner v8 serialization fails
4 participants
@MoLow @nodejs-github-bot @cjihrig @benjamingr