Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent version table of CustomEvent #55733

Closed
skyclouds2001 opened this issue Nov 5, 2024 · 2 comments · Fixed by #55758
Closed

Inconsistent version table of CustomEvent #55733

skyclouds2001 opened this issue Nov 5, 2024 · 2 comments · Fixed by #55758
Labels
doc Issues and PRs related to the documentations.

Comments

@skyclouds2001
Copy link
Contributor

skyclouds2001 commented Nov 5, 2024 •
edited
Loading

Affected URL(s)

https://nodejs.org/docs/latest/api/globals.html#customevent, https://nodejs.org/docs/latest/api/events.html#class-customevent

Description of the problem

The version table of CustomEvent is inconsistent, both missed some useful information, see mdn/browser-compat-data#24955 for my full research

for globals:

image

for events:

image
@skyclouds2001 skyclouds2001 added the doc Issues and PRs related to the documentations. label Nov 5, 2024
@skyclouds2001 skyclouds2001 mentioned this issue Nov 5, 2024
Merged
@RedYetiDev
Copy link
Member

RedYetiDev commented Nov 5, 2024 •
edited
Loading

PRs are always welcome

Seems like we just need to merge the tables, and then it'll have everything it needs.

@skyclouds2001
Copy link
Contributor Author

PRs are always welcome

Seems like we just need to merge the tables, and then it'll have everything it needs.

Got it!

@geeksilva97 geeksilva97 mentioned this issue Nov 7, 2024
Merged
aduh95 pushed a commit that referenced this issue Nov 9, 2024
@geeksilva97 @aduh95
doc: consolidate history table of CustomEvent
355af0f 
PR-URL: #55758
Fixes: #55733
Refs: #55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
geeksilva97 added a commit to geeksilva97/node that referenced this issue Nov 10, 2024
@geeksilva97
doc: consolidate history table of CustomEvent
38d031b 
PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@geeksilva97 geeksilva97 mentioned this issue Nov 10, 2024
Closed
geeksilva97 added a commit to geeksilva97/node that referenced this issue Nov 11, 2024
@geeksilva97
doc: consolidate history table of CustomEvent
da5be81 
PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
ruyadorno pushed a commit that referenced this issue Nov 21, 2024
@geeksilva97 @ruyadorno
doc: consolidate history table of CustomEvent
9ffd2dd 
PR-URL: #55758
Backport-PR-URL: #55805
Fixes: #55733
Refs: #55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
@geeksilva97 @tpoisseau
doc: consolidate history table of CustomEvent
ab7c959 
PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Nov 26, 2024
@geeksilva97 @Ceres6
doc: consolidate history table of CustomEvent
6c031a3 
PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: consolidate history table of CustomEvent geeksilva97/node
2 participants
@RedYetiDev @skyclouds2001