Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.x backport] doc: consolidate history table of CustomEvent #55805

Closed
wants to merge 1 commit into from
Closed

[v22.x backport] doc: consolidate history table of CustomEvent #55805

wants to merge 1 commit into from

Conversation

geeksilva97
Copy link
Contributor

Backport of: #55758
Fixes: #55733
Refs: #55733

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Nov 10, 2024
@geeksilva97 geeksilva97 marked this pull request as ready for review November 10, 2024 02:15
@aduh95
Copy link
Contributor

aduh95 commented Nov 10, 2024

The commit message should be the same as the one that landed on 23.x (355af0f), including the metadata (Reviewed-by, PR-URL, etc.). It should also have the same author and date.

@geeksilva97
doc: consolidate history table of CustomEvent
da5be81 
PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@geeksilva97
Copy link
Contributor Author

The commit message should be the same as the one that landed on 23.x (355af0f), including the metadata (Reviewed-by, PR-URL, etc.). It should also have the same author and date.

Got it. It's fixed!

ruyadorno pushed a commit that referenced this pull request Nov 21, 2024
@geeksilva97 @ruyadorno
doc: consolidate history table of CustomEvent
9ffd2dd 
PR-URL: #55758
Backport-PR-URL: #55805
Fixes: #55733
Refs: #55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@ruyadorno
Copy link
Member

Landed in 9ffd2dd

@ruyadorno ruyadorno closed this Nov 21, 2024
@ruyadorno
Copy link
Member

vlw @geeksilva97! 👍

@geeksilva97
Copy link
Contributor Author

vlw @geeksilva97! 👍

Anytime 🇧🇷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geeksilva97 @aduh95 @ruyadorno @nodejs-github-bot