Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up canned small-icu build #7253

Closed
srl295 opened this issue Jun 10, 2016 · 7 comments
Closed

speed up canned small-icu build #7253

srl295 opened this issue Jun 10, 2016 · 7 comments
Assignees
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Jun 10, 2016

Version: HEAD
Platform: !win (at this point)
Subsystem: deps/icu

When using canned small-icu (the default for configure && make), AND on little endian systems, we can avoid building some things we're currently building.

This isn't a great speedup, but it does:

  • reduce the number of files to compile from about 2,130 to 1,901 - so about 11% of the files reduced
  • On my test machine, a compile went from 27m17s to 25m55s - so about 5%
  • Reduce a few of the system headers needed (maybe) in some scenarios such as Failed to compile from source for armv7l (busybox) on  #7173

(details: in this scenario, only genccode needs to be compiled on the ICU side, and it doesn't need the i18n or io libraries).

@srl295 srl295 added build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. labels Jun 10, 2016
@srl295 srl295 self-assigned this Jun 10, 2016
srl295 added a commit to srl295/node that referenced this issue Jun 10, 2016
When:
* using canned,  small-icu (the default for configure && make)
* .. on little endian systems

we can avoid building some things we're currently building.

Namely, on the host toolchain side in this scenario, only genccode needs to be compiled,
and it doesn't need the i18n or io libraries

Fixes: nodejs#7253
@srl295
Copy link
Member Author

srl295 commented Jun 10, 2016

let me know if there's any interest in this. It speeds up the default for people doing configure so could be worthwhile.

@mscdex
Copy link
Contributor

mscdex commented Jun 10, 2016

Anything to speed up build time is good IMHO, even if it's not a speedup on all platforms.

@srl295
Copy link
Member Author

srl295 commented Jun 10, 2016

@mscdex thanks.

  • nothing windows specific here- just didn't port the change yet

@jasnell
Copy link
Member

jasnell commented Aug 9, 2016

What's the status on this?

@srl295
Copy link
Member Author

srl295 commented Jan 16, 2017

@jasnell probably nothing that wouldn't still build, just needs testing.

@jasnell
Copy link
Member

jasnell commented May 30, 2017

ping @srl295

@srl295
Copy link
Member Author

srl295 commented Mar 26, 2018

close this in favor of #19214 (we won't want to do both!)

@srl295 srl295 closed this as completed Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants