Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup canned small-icu build #7254

Closed
wants to merge 1 commit into from
Closed

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jun 10, 2016

Checklist
  • make -j4 test (UNIX) and
  • vcbuild test nosign (Windows) passes
  • test on big endian
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

When:

  • using canned, small-icu (the default for configure && make)
  • .. on little endian systems

we can avoid building some things we're currently building.

Namely, on the host toolchain side in this scenario, only genccode needs to be compiled,
and it doesn't need the i18n or io libraries

Fixes: #7253

When:
* using canned,  small-icu (the default for configure && make)
* .. on little endian systems

we can avoid building some things we're currently building.

Namely, on the host toolchain side in this scenario, only genccode needs to be compiled,
and it doesn't need the i18n or io libraries

Fixes: nodejs#7253
@mscdex mscdex added i18n-api Issues and PRs related to the i18n implementation. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Jun 10, 2016
@srl295 srl295 self-assigned this Jun 10, 2016
@srl295
Copy link
Member Author

srl295 commented Jun 10, 2016

Started a CI build.

i18n.cc:(.text._ZN2v88internal12_GLOBAL__N_117CreateICUCollatorEPNS0_7IsolateERKN6icu_576LocaleENS0_6HandleINS0_8JSObjectEEE+0x2c): undefined reference to `icu_57::Collator::createInstance(icu_57::Locale const&, UErrorCode&)'
collect2: error: ld returned 1 exit status
make[1]: *** [/home/iojs/build/workspace/node-cross-compile/label/cc-armv6/out/Release/mksnapshot] Error 1

^ May need to re-include some stuff when cross-compiling.

@jasnell
Copy link
Member

jasnell commented Aug 9, 2016

@srl295 ... what's the status on this?

@jasnell
Copy link
Member

jasnell commented Mar 1, 2017

ping @srl295 ... does this need to stay open?

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Mar 1, 2017
@srl295
Copy link
Member Author

srl295 commented Mar 1, 2017 via email

@fhinkel
Copy link
Member

fhinkel commented May 26, 2017

Ok, thanks @srl295 . Closing this.

@fhinkel fhinkel closed this May 26, 2017
@refack
Copy link
Contributor

refack commented May 30, 2017

Cross-Ref: #12218
@srl295 is the icutrim.py patch an import from a different repo?

@srl295
Copy link
Member Author

srl295 commented Aug 30, 2017

@refack icutrim.py is in a branch in ICU. but I have never landed it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. stalled Issues and PRs that are stalled. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speed up canned small-icu build
5 participants