Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: repl deprecation styling results in unreadable text #9714

Closed
mscdex opened this issue Nov 20, 2016 · 1 comment
Closed

doc: repl deprecation styling results in unreadable text #9714

mscdex opened this issue Nov 20, 2016 · 1 comment
Assignees
@silverwind
Labels
doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Nov 20, 2016

  • Version: v7.x
  • Platform: n/a
  • Subsystem: doc

The styling of backtick blocks in deprecation messages was changed at some point for v7.x docs, causing this deprecation to be white on gray on red, making the text unreadable.
@mscdex mscdex added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Nov 20, 2016
@Fishrock123
Copy link
Contributor

This is probably due to f1a3755#diff-fa6d04f9f0d2df5a1320c28106ea0a32L356

Deprecation blocks should probably override it separately (per color?).

@silverwind silverwind self-assigned this Nov 21, 2016
silverwind added a commit to silverwind/node that referenced this issue Nov 21, 2016
@silverwind
doc: make <code> background semi-transparent
9a8dc80 
Fixes: nodejs#9714
@silverwind silverwind mentioned this issue Nov 21, 2016
Closed
2 tasks
addaleax pushed a commit that referenced this issue Dec 5, 2016
@silverwind @addaleax
doc: fix <code> inside stability boxes
44ae028 
Fixes: #9714
PR-URL: #9723
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silverwind silverwind

Labels
doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @silverwind @Fishrock123