Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix <code> inside stability boxes #9723

Closed
wants to merge 2 commits into from
Closed

doc: fix <code> inside stability boxes #9723

wants to merge 2 commits into from

Conversation

silverwind
Copy link
Contributor

@silverwind silverwind commented Nov 21, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools, doc

Description of change

Mades <code> backgrounds semi-transparent so they work on all backgrounds. The inline blocks are rendered as #f2f2f2 before and after this change.

Before

After

Fixes: #9714

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 21, 2016
@silverwind
Copy link
Contributor Author

silverwind commented Nov 21, 2016 •
edited
Loading

Decided to change the background color to be more apparent and restored the padding on the code block because it went missing in a recent commit that styled pre > code which inadvertently affected these tags too:

@silverwind silverwind changed the title doc: make <code> background semi-transparent doc: fix <code> inside stability boxes Nov 21, 2016
Fishrock123
Fishrock123 approved these changes Nov 21, 2016
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@silverwind
Copy link
Contributor Author

Thanks! Landed in 245a928.

@silverwind silverwind closed this Nov 22, 2016
@silverwind silverwind deleted the doc-code-bg branch November 22, 2016 18:40
silverwind added a commit that referenced this pull request Nov 22, 2016
@silverwind
doc: fix <code> inside stability boxes
245a928 
Fixes: #9714
PR-URL: #9723
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mscdex
Copy link
Contributor

mscdex commented Nov 22, 2016

I don't think this needs to be backported to 4.x or 6.x, unless the style changes that created the issue are also backported.

@silverwind
Copy link
Contributor Author

Right, the issue is not present in 6.x. I first thought it was introduced earlier.

@MylesBorins
Copy link
Contributor

@silverwind thanks for figuring out LTS related stuff! In future if you could include the dont-land tags that would help a ton!

addaleax pushed a commit that referenced this pull request Dec 5, 2016
@silverwind @addaleax
doc: fix <code> inside stability boxes
44ae028 
Fixes: #9714
PR-URL: #9723
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @mscdex @MylesBorins @Fishrock123 @lpinca @nodejs-github-bot