Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: validate errors in test-buffer-indexof #10752

Closed
wants to merge 1 commit into from
Closed

test: validate errors in test-buffer-indexof #10752

wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented Jan 12, 2017

  • validate errors in assert.throws
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@edsadr
test: validate errors in test-buffer-indexof
7282a6b 
* validate errors in assert.throws
* use arrow functions
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 12, 2017
@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Jan 12, 2017
@lpinca
Copy link
Member

lpinca commented Jan 16, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5880/

@lpinca
Copy link
Member

lpinca commented Jan 16, 2017

Landed in f51d4f3.

@lpinca lpinca closed this Jan 16, 2017
lpinca pushed a commit that referenced this pull request Jan 16, 2017
@edsadr @lpinca
test: validate errors in test-buffer-indexof
f51d4f3 
* validate errors in assert.throws
* use arrow functions

PR-URL: #10752
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@edsadr @italoacasas
test: validate errors in test-buffer-indexof
1e3dac6 
* validate errors in assert.throws
* use arrow functions

PR-URL: nodejs#10752
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas
Copy link
Contributor

italoacasas commented Jan 23, 2017 •
edited
Loading

Because of beca324 .This need to be backported

targos pushed a commit that referenced this pull request Jan 28, 2017
@edsadr @targos
test: validate errors in test-buffer-indexof
db3cb66 
* validate errors in assert.throws
* use arrow functions

PR-URL: #10752
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr @italoacasas
test: validate errors in test-buffer-indexof
807e99b 
* validate errors in assert.throws
* use arrow functions

PR-URL: nodejs#10752
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr @italoacasas
test: validate errors in test-buffer-indexof
94c9631 
* validate errors in assert.throws
* use arrow functions

PR-URL: nodejs#10752
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Jun 19, 2017
Closed
2 tasks
gibfahn pushed a commit that referenced this pull request Jun 19, 2017
@edsadr @gibfahn
test: validate errors in test-buffer-indexof
493f072 
* validate errors in assert.throws
* use arrow functions

PR-URL: #10752
Backport-PR-URL: #13785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@edsadr @gibfahn
test: validate errors in test-buffer-indexof
9243b9d 
* validate errors in assert.throws
* use arrow functions

PR-URL: #10752
Backport-PR-URL: #13785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@edsadr @MylesBorins
test: validate errors in test-buffer-indexof
752bc24 
* validate errors in assert.throws
* use arrow functions

PR-URL: #10752
Backport-PR-URL: #13785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
@edsadr @targos
test: validate errors in test-buffer-indexof
85b17c1 
* validate errors in assert.throws
* use arrow functions

PR-URL: nodejs/node#10752
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@edsadr @lpinca @italoacasas @jasnell @cjihrig @mscdex @targos @nodejs-github-bot