v7.5.0 proposal #11062
Merged
v7.5.0 proposal #11062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destroy_ids_idle_handle_ needs to be closed on environment destruction. Not closing the handle leaves a dangling pointer in the used uv loop. This leads to undefined behavior when the uv loop is used after the environment has been destroyed. PR-URL: #10385 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
* use common.mustCall() where appropriate * Buffer.allocUnsafe() -> Buffer.alloc() * do crypto check before loading any additional modules * specify 1ms duration for `setTimeout()` PR-URL: #10225 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
We were transporting the heap statistics as uint32 values to JS land but those wrap around for values > 4 GB. Use 64 bits floats instead, those should last us a while. Fixes: #10185 PR-URL: #10186 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: #7837 PR-URL: #8645 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #10510 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
See: https://url.spec.whatwg.org/#dom-url-origin Also moves the tests for origins to the parsing tests since now URL#origin matches the test cases by default. PR-URL: #10552 Reviewed-By: James M Snell <jasnell@gmail.com>
new year new alias PR-URL: #10586 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Remove the numbers from the comments to make it clear that assert does not follow the [CJS spec](http://wiki.commonjs.org/wiki/Unit_Testing/1.0). Additionally, clean up the existing comments for consistent formatting/language and ease of reading. PR-URL: #10579 Fixes: #9063 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This updates util.inspect() to avoid accessing out-of-range indices of the `arguments` object, which is known to cause optimization bailout. Based on an average of 10 runs of the benchmark in `benchmark/util/inspect.js`, this change improves the performance of `util.inspect` by about 10%. Relates to #10323 PR-URL: #10569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
punycode/ICU is not specific to any particular module, so move it to a more generic location. PR-URL: #10446 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #10446 Reviewed-By: James M Snell <jasnell@gmail.com>
Some benchmarks' results are small values, so keeping decimals when running them manually (not comparing) can be helpful. PR-URL: #10559 Reviewed-By: James M Snell <jasnell@gmail.com>
array.shift() seems to be faster than arrayClone() when the item to remove is at the front (at least with V8 5.4). PR-URL: #10572 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
These changes result in ~50% improvement in the included benchmark. PR-URL: #10580 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* use const instead of var * use common.mustCall to control functions execution * use assert.strictEqual instead of assert.equal * use arrow functions * remove console.error PR-URL: #10521 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
We have had #9728 open for a while but the frequency of the failures seems to be such that we should mark it as flaky while we continue to investigate. PR-URL: #10618 Reviewed-by: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit makes sure EventEmitter.emit() doesn't get deoptimized by V8. The deopt happens when accessing out of bound indexes of the `arguments` object. This issue has been raised here: #10323 and this specific case might become a more serious performance issue in upcoming V8 releases. PR-URL: #10568 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #10568 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Add the nodejs/python github team to the table of people to /cc for reviews on python code. PR-URL: #10637 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Pulls in new URL parsing tests from w3c web-platform-tests and updates null password handling. Refs: web-platform-tests/wpt@e001240 Refs: whatwg/url#186 PR-URL: #10601 Fixes: #10595 Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Per a recent change to the URL spec, arbitrary %2e sequences in URL paths that are not single or double dot segments are not to be decoded. Refs: whatwg/url#87 Refs: whatwg/url#156 Refs: web-platform-tests/wpt@d93247d Fixes: #10598 PR-URL: #10602 Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fixes: nodejs/CTC#41 PR-URL: #10604 Fixes: https://github.com/nodejs/CTC#41 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use arrow functions and prefer `strictEqual` over `deepStrictEqual` where it works. PR-URL: #10611 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Keepalive sockets that are returned to the agent's freesocket pool were previously capturing a reference to the ClientRequest that initiated the request. This commit eliminates that by moving the installation of the socket listeners to a different function. PR-URL: #10134 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* use let instead of var * use assert.strictEqual instead of assert.equal * swap assertions arguments to match the standard PR-URL: #10600 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, when test/cctest/test_inspector_socket_server.cc is run there is output written to stderr by src/inspector_socket_server.cc which is interleaved with the gtest report: Debugger listening on port 9229. Warning: This is an experimental feature and could change at any time. To start debugging, open the following URLs in Chrome: ... The goal of this commit is to remove the above logged information by introducing an out_ member in the InspectorSocketServer class which defaults to stderr (keeping the current behavior). Setting out_ to NULL is supported in which case nothing will be written and is what the test has been configured with. When working on specific test case the appropriate output stream can be specified for the ServerHolder constructor to limit logging to that test case. PR-URL: #10537 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ESLint `indent` rule now has options that duplicate functionality in our custom `align-function-arguments` rule. Remove `align-function-arguments` custom rule. PR-URL: #10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
The `no-useless-regex-char-class-escape` custom lint rule was introduced as a less aggressive alternative to some enhancements that were introduced into ESLint. Those enhancements were blocking us from updating ESLint. However, they have since been relaxed and the custom rule is no longer needed. Remove it. PR-URL: #10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
There are places in the code base where setTimeout() or setInterval() are called with just a callback and no duration/interval. The timers module will use a value of `1` in that situation. An unspecified duration or interval can be confusing. Did the original author forget to provide a value? Did they intend to use setImmediate() or process.nextTick() instead of setTimeout()? And so on. This change provides a duration or interval of `1` to all calls in the codebase where it is missing. `parallel/test-timers.js` still tests the situation where `setTimeout()` and `setInterval()` are called with `undefined` and other non-numeric values for the duration/interval. PR-URL: #9472 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add a custom ESLint rule to require that setTimeout() and setInterval() get called with at least two arguments. This prevents omitting the duration or interval. PR-URL: #9472 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #10964 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Calling `.As<Object>()` on a non-object aborts in debug mode, but `node_url.cc` relied on it. Address that by using `Local<Value>` until it has been confirmed that the handle actually is an object. PR-URL: #11064 Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
* Add an exception test. * Add `common.mustCall()`. * Make use of Arrow function. PR-URL: #11034 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
removed unneccessary curly braces and return statement from inspect arrow function updated `assert.throws` regex to look for exact match at start of string PR-URL: #11039 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #11020 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #11080 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
When parameter count is fixed, use literal Array instance is more simply and avoid arguments leak also. PR-URL: #10833 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #11085 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Use `common.mustCall()` to guarantee that the wrapped `_refreshSize()` functions are invoked. PR-URL: #11068 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com>
PR-URL: #11061 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
`port` was listed as required, but as described in the following paragraphs, it's actually not. Also, note that setting `port` to `0` will also cause the OS to assign a a random port and sync up the docs of both forms. PR-URL: #11025 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Notable changes: * crypto: * ability to select cert store at runtime (Adam Majer) #8334 * Use system CAs instead of using bundled ones (Adam Majer) #8334 * deps: * upgrade npm to 4.1.2 (Kat Marchán) #11020 * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021 * doc: add basic documentation for WHATWG URL API (James M Snell) #10620 * process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842 * url: allow use of URL with http.request and https.request (James M Snell) #10638 PR-URL: #11062
evanlucas
force-pushed
the
v7.5.0-proposal
branch
from
42b4cee to
a34f1d6
Compare
PR-URL: #11062
evanlucas
added a commit
that referenced
this pull request
Feb 1, 2017
Notable changes: * crypto: * ability to select cert store at runtime (Adam Majer) #8334 * Use system CAs instead of using bundled ones (Adam Majer) #8334 * deps: * upgrade npm to 4.1.2 (Kat Marchán) #11020 * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021 * doc: add basic documentation for WHATWG URL API (James M Snell) #10620 * process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842 * url: allow use of URL with http.request and https.request (James M Snell) #10638 PR-URL: #11062
evanlucas
added a commit
to evanlucas/nodejs.org
that referenced
this pull request
Feb 1, 2017
evanlucas
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 1, 2017
|
Thats so sad :( It was previously mentioned that #11029 would be merged into this release. Is there any 7.x releases planned or we have to wait 3 months and expecting v8 > 5.5 ? |
|
@pi0 don't be sad... we just need to make sure the build is safe before releasing it. I spun up a test build of v7.5.0 with the V8 update if you want to test it out (give it another 30 minutes or so until it is done building) https://nodejs.org/download/test/v7.5.1-test20170201baf1e18b0c/ You can install it with nvm too |
|
@pi0 we cut v7.x releases at least every other week, so you shouldn't have to wait too long provided the PR gets approval by someone. :] |
imyller
added a commit
to imyller/meta-nodejs
that referenced
this pull request
Mar 2, 2017
Notable changes:
* crypto:
* ability to select cert store at runtime (Adam Majer) #8334
* Use system CAs instead of using bundled ones (Adam Majer) #8334
* deps:
* upgrade npm to 4.1.2 (Kat Marchán) #11020
* upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021
* doc: add basic documentation for WHATWG URL API (James M Snell) #10620
* process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842
* url: allow use of URL with http.request and https.request (James M Snell) #10638
PR-URL: nodejs/node#11062
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-01-31, Version 7.5.0 (Current), @evanlucas
Thank you to @italoacasas for preparing the majority of this release.
This release contains security fixes to upgrade OpenSSL to version 1.0.2k.
Although the OpenSSL team have determined a maximum severity rating of "moderate", the Node.js
crypto team (Ben Noordhuis, Shigeki Ohtsu and Fedor Indutny) have determined the impact to Node
users is "low". Details on this determination can be found
on the Nodejs.org website.
Notable changes
Commits
61f6f1260d] - (SEMVER-MINOR) src/doc: improve man page and --help (Roman Reiss) #10157b2d0c44fb1] - assert: update comments (Kai Cataldo) #10579c217b438f2] - assert, tools: enforce strict (not)equal in eslint (Gibson Fahnestock) #1069894c4323d56] - async_wrap: close the destroy_ids_idle_handle_ (René Schünemann) #10385f61c71b533] - benchmark: add progress indicator to compare.js (Joyee Cheung) #10823ccdc922ada] - benchmark: move setImmediate benchmarks to timers (Joshua Colvin) #11010062c8513ad] - benchmark: add more thorough timers benchmarks (Jeremiah Senkpiel) #109251e0294ccc9] - benchmark: add benchmark for object properties (Michaël Zasso) #1094947c0953b12] - benchmark: add benchmark for vm.runIn*() (Rich Trott) #108162f339e7200] - benchmark: cleanup child_process IPC benchmark (Yuya Tanaka) #10557eac1871c45] - benchmark: improve WHATWG URL benchmarks (Joyee Cheung) #10678ecf72d8b54] - benchmark: use "confidence" in output of compare.R (Joyee Cheung) #1073735334273b9] - benchmark: don't lint autogenerated modules (Brian White) #107564f96272f12] - benchmark: fix typo "categoty" -> "category" (Victor Felder) #105682f4577c07d] - benchmark: keep decimals in results (Brian White) #10559372e3eeb4b] - benchmark: improve readability of net benchmarks (Brian White) #10446d19136da84] - benchmark: move punycode benchmark out of net (Brian White) #10446be24cc0187] - benchmark: add ClientRequest creation benchmark (Brian White) #106541438d00119] - benchmark,lib,test: adjust for linting (Rich Trott) #10561d13aba8499] - buffer: improve compare() performance (Brian White) #109276549bc2a35] - buffer: fix comments in bidirectionalIndexOf (dcposch@dcpos.ch) #10162a114f63627] - buffer: improve toJSON() performance (Brian White) #108959c2f686f7e] - build: don't build deps/zlib if --shared-zlib set (Gibson Fahnestock) #10657659428fe1d] - build: sort sources alphabetically (Daniel Bevenius) #1089274f9cc9f0a] - build: move source files from headers section (Daniel Bevenius) #10850a408ba6454] - build: don't squash signal handlers with --shared (Stewart X Addison) #10539ddcd1a202f] - child_process: optimize IPC for large data (Yuya Tanaka) #10557d751afae0f] - cluster: refactor module into multiple files (cjihrig) #107466687b95263] - crypto: return the retval of HMAC_Update (Travis Meisenheimer) #10891a1897c1445] - (SEMVER-MINOR) crypto: ability to select cert store at runtime (Adam Majer) #8334aeea13b6f6] - (SEMVER-MINOR) crypto: Use system CAs instead of using bundled ones (Adam Majer) #8334ac2b059500] - (SEMVER-MINOR) crypto: do not use pointers to std::vector (Adam Majer) #83345fd0f9ae63] - crypto: freelist_max_len is gone in OpenSSL 1.1.0 (Adam Langley) #108594e7a31b3a0] - crypto,tls: fix mutability of return values (Rich Trott) #107959e60af893c] - deps: upgrade npm to 4.1.2 (Kat Marchán) #11020da59a57d60] - deps: limit regress/regress-crbug-514081 v8 test (Michael Dawson) #6678edd20720ac] - deps: update openssl asm and asm_obsolete files (Shigeki Ohtsu) #11021ce20ad76ec] - deps: add -no_rand_screen to openssl s_client (Shigeki Ohtsu) nodejs/io.js#183606f87c3e0a] - deps: fix asm build error of openssl in x86_win32 (Shigeki Ohtsu) iojs/io.js#1389093cacf61b] - deps: fix openssl assembly error on ia32 win32 (Fedor Indutny) iojs/io.js#1389a3b3b35c53] - deps: copy all openssl header files to include dir (Shigeki Ohtsu) #110216a0f1fabb1] - deps: upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #110211fae98b833] - deps: upgrade npm to 4.1.1 (Rebecca Turner) #107816e0888ad9e] - deps: add test for v8 bug in toUpper('ç') (Steven R. Loomis) #98281c4bf9e8ff] - deps: cherry-pick 2f5da9a from V8 upstream (Steven R. Loomis) #9828ffd938a694] - deps: upgrade libuv to 1.10.2 (cjihrig) #10717aa6b9f979e] - deps: cherry-pick baba152 from V8 upstream (Michaël Zasso) #106885887396150] - deps: cherry-pick a814b8a from upstream V8 (ishell@chromium.org) #1073355e98c66c0] - doc: add abouthiroppy to collaborators (Yuta Hiroto) #11080722ae8700f] - doc: add who to CC list for dgram (cjihrig) #11035a8533acee6] - doc: change logical to bitwise OR in dns lookup (Sakthipriyan Vairamani (thefourtheye)) #11037ac36d78d56] - doc: fix typo in http.md (Peter Mescalchin) #109750bf3b24771] - doc: remove Chris Dickinson from active releasers (Ben Noordhuis) #110119ca404ed25] - doc: for style, remove "isn't" contraction (Sam Roberts) #109814be9e98448] - doc: make os api doc more consistent (Evan Lucas) #109947dff6aa67f] - doc: update http.md for consistency and clarity (Lance Ball) #10715dd608591a8] - doc: clarify Buffer.indexOf/lastIndexOf edge cases (dcposch@dcpos.ch) #101625250b3358e] - doc: document argument variant in the repl.md (Vse Mozhet Byt) #10221c4b9f0a75e] - doc: DEFAULT_ECDH_CURVE was added in 0.11.13 (Sam Roberts) #1098384e2ff3738] - (SEMVER-MINOR) doc: add basic documentation for WHATWG URL API (James M Snell) #106209d91bf9788] - doc: HTTP response getHeader doc fix (Faiz Halde) #1081706acf88117] - doc: remove duplicate properties bullet in readme (Javis Sullivan) #1074109ac2a2cb7] - doc: specify sorted requires in tests (Sam Roberts) #10716f380a5fb5a] - doc: mention cc-ing nodejs/python team for reviews (Anna Henningsen) #1063758bb263438] - doc: update TheAlphaNerd to MylesBorins (Myles Borins) #105861253650cf4] - doc: update examples in api/crypto.md (Vse Mozhet Byt) #109093177d6557a] - doc: move topics/guides to website (Evan Lucas) #10896d2896d92a7] - doc: update AUTHORS list to fix name (Noah Rose Ledesma) #109454ffcefdc09] - doc: add TimothyGu to collaborators (Timothy Gu) #109543fcf0aed4a] - doc: mention moderation repo in onboarding doc (Anna Henningsen) #1086979d8db0fef] - doc: add edsadr to collaborators (Adrian Estrada) #10883520b1f7853] - doc: clarifying variables in fs.write() (Jessica Quynh Tran) #9792daf1bf588b] - doc: add links for zlib convenience methods (Anna Henningsen) #10829aeaf887700] - doc: fix markdown escaping in CHANGELOG_V7.md (Anna Henningsen) #10827c8b0fc6d8b] - doc: remove duplicate PR link from changelog (Anna Henningsen) #10827049258b062] - doc: fixupaddedtags in cli.md (Anna Henningsen) #1082661798d1fa4] - doc: add missingadded:tag forzlib.constants(Anna Henningsen) #1082673939ec701] - doc: clarify memory sharing behavior of buffer ctor (Zach Bjornson) #10778f8b081b519] - doc: fix broken internal link in process.md (Anna Henningsen) #10828a53f881f57] - doc: update writable.write return value (Nathan Phillip Brink) #105826e1a3d1e57] - doc: use correct tls certificate property name (Sam Roberts) #1038923edfe00b3] - doc: edit writing-tests.md (Rich Trott) #105859b73a8524f] - doc: fix misleading language in vm docs (Alexey Orlenko) #1070856ea7eb9a7] - doc: mention cc-ing nodejs/url team for reviews (Anna Henningsen) #1065266b34eac2f] - doc: sort require statements in tests (Sam Roberts) #10616238466bcf0] - doc: handle backpressure when write() return false (Matteo Collina) #10631ec226a2a3b] - doc: add test naming information to guide (Rich Trott) #10584b73e98bf48] - doc: fix missing negation in stream.md (Johannes Rieken) #10712bf95b074cd] - doc: "s/git apply/git am -3" in V8 guide (Myles Borins) #106659c89b2f704] - doc: update LTS info for current releases (Evan Lucas) #107203f1775707e] - doc: correct vcbuild options for windows testing (Jonathan Boarman) #106868314d9ee73] - doc: killSignal option accepts integer values (Sakthipriyan Vairamani (thefourtheye)) #10424736a7f3dd3] - doc: update BUILDING.md (Lukasz Gasior) #10669f81bd48818] - doc: document use of Refs: for references (Gibson Fahnestock) #10670b70dde0050] - doc: new TLSSocket has no secure context options (Sam Roberts) #10545d3628d9e47] - doc: modernize child_process example code (Vse Mozhet Byt) #101023270d4c89b] - doc: clarify information about ABI version (Rich Trott) #104191fca69c263] - doc,test: tls .ca option supports multi-PEM files (Sam Roberts) #1038978a495e1a4] - eslint: remove dangling eslint symlink (Sam Roberts) #107715cca69320f] - events: avoid emit() eager deopt (Victor Felder) #10568ded17579e5] - events: improve removeListener() performance (Brian White) #10572d047f8e8f8] - fs: remove unused parameter for encodeRealpathResult (Jackson Tian) #10862c32984361a] - http: make request.abort() destroy the socket (Luigi Pinca) #108188ba2cf9c51] - http: define all used properties in constructors (vitkarpov) #911675aa6050ab] - http: eliminate capture of ClientRequest in Agent (Evan Torrie) #101345059b76cbc] - http: misc ClientRequest cleanup (Brian White) #1065444c0e4f1ad] - http: avoid duplicate isArray() (Brian White) #10654e7859c217f] - http: optimize default method case (Brian White) #10654c9bff043c7] - http: optimize short path validation (Brian White) #10654c012dd79dc] - https: Use secureProtocol in Agent#getName (Andreas Lind) #94529a111e701e] - inspector: no crash when WS server can't start (Eugene Ostroukhov) #108782d08bbadd6] - inspector: stop relying on magic strings (Eugene Ostroukhov) #10159e30e307a70] - inspector: move options parsing (Eugene Ostroukhov) #969160f27f91e4] - inspector: remove unused uv_async_t (Eugene Ostroukhov) #10392a3abba0b1a] - lib: remove unnecessary parameter for assertCrypto() (Jackson Tian) #108344de7b03a7d] - lib: refactor bootstrap_node.js regular expression (Rich Trott) #10749a6c93af244] - lib: refactor crypto cipher/hash/curve getters (Rich Trott) #106826e8d627217] - lib,src: support values > 4GB in heap statistics (Ben Noordhuis) #10186de8eee6b16] - meta: decharter the http working group (James M Snell) #106044caa0126aa] - openssl: fix keypress requirement in apps on win32 (Shigeki Ohtsu) iojs/io.js#1389d24491c6a7] - (SEMVER-MINOR) process: add NODE_NO_WARNINGS environment variable (cjihrig) #1084297ff43232b] - querystring: improve unescapeBuffer performance (Brian White) #10837f4796d5f6e] - querystring: improve stringify() performance (Brian White) #1085253421b174c] - querystring: improve parse() performance (Brian White) #10874d64e2371f6] - readline: refactor construct Interface (Jackson Tian) #4740e7b656db6e] - Revert "repl: disable Ctrl+C support on win32 for now" (Anna Henningsen) #8645a24264eb18] - src: fix v8 local handling in node_url.cc (Anna Henningsen) #110648a6367cb20] - Revert "src: don't overwrite non-writable vm globals" (Anna Henningsen) #10920978acd138f] - (SEMVER-MINOR) src: support "--" after "-e" as end-of-options (John Barboza) #10651cd94642356] - src: add NODE_NO_WARNINGS to --help output (cjihrig) #1091863f43021b0] - src: remove unused PROTOCOL_JSON array (Ben Noordhuis) #104075a976decf7] - src: remove unnecessary req_wrap_obj (Daniel Bevenius) #109420c0334f7a4] - src: add a missing space in node_os.cc (Alexey Orlenko) #10931b89d848b36] - src: enable writev for pipe handles on Unix (Alexey Orlenko) #10677f0de955220] - src: reduce test_inspector_socket_server output (Daniel Bevenius) #1053759196af646] - stream: avoid additional validation for Buffers (Brian White) #10580e367b74c4f] - test: add an exception test to http-write-head (Yuta Hiroto) #1103465691d68d5] - test: increase coverage of internal/util (DavidCai) #109640753bc17b6] - test: increase timeout in break-on-uncaught (Sakthipriyan Vairamani (thefourtheye)) #10822eff3a48e63] - test: add known_issues test for Object.defineProperty on the global object does not handle 'writable' properly in vm context #10223 (AnnaMag) #1102472a97b66dc] - test: guarantee test runs in test-readline-keys (Rich Trott) #11023e3a316f3e6] - test: check error message in test-http-outgoing-proto (Alex Ling) #10943fcd08b8a1e] - test: add tests for searchParams (abouthiroppy) #10952f3efaeed35] - test: increase coverage for stream's duplex (abouthiroppy) #10963b5e8413c3f] - test: allow for slow hosts in spawnSync() test (Rich Trott) #10998cfd1b19c34] - test: expand test coverage of fs.js (Vinícius do Carmo) #109474aedde8d82] - test: expand test coverage of events.js (Vinícius do Carmo) #10947c1e166a168] - test: check noAssert option in buf.write*() (larissayvette) #10790580a453fcf] - test: expand test coverage of fs.js (Vinícius do Carmo) #10972fa8baa2aa1] - test: enhance test-timers (Rich Trott) #1096074ff804dbd] - test: add regression tests for vm bugs (Anna Henningsen) #109201a39bfb7e2] - test: increase coverage for exec() functions (cjihrig) #109194b38744e9b] - test: add process.assert's test (abouthiroppy) #10911e7c953a5f9] - test: update Buffer.lastIndexOf (dcposch@dcpos.ch) #10162eb7ee50717] - test: improve code in test-crypto-verify (Adrian Estrada) #10845efa9845946] - test: refactor test-cli-eval.js (cjihrig) #10898b7bf43aa2b] - test: use common.fail() instead of assert(false) (cjihrig) #1089990a99177a3] - test: add dgram.Socket.prototype.bind's test (abouthiroppy) #10894dc826caed2] - test: update V8 flag in test (Franziska Hinkelmann) #10917537d954ed2] - test: increase coverage of string-decoder (abouthiroppy) #108633cd9833eff] - test: add tests for rs+, sr+ to test-fs-open-flags.js (abouthiroppy) #10780c8a069e544] - test: improving coverage of dns-lookup (abouthiroppy) #10844939517abfd] - test: refactor test-fs-read-zero-length.js (abouthiroppy) #10729ffdf605f14] - test: improving coverage for dgram (abouthiroppy) #107831666600f16] - test: improve code in test-console-instance (Adrian Estrada) #10813b496374363] - test: improve code in test-domain-multi (Adrian Estrada) #1079846bbabe6c2] - test: improve test-stream2-large-read-stall (stefan judis) #107257f043779eb] - test: improve code in test-http-host-headers (Adrian Estrada) #1083066c57a24c2] - test: add test case to test-http-response-statuscode.js (abouthiroppy) #108084a7bb5b4d1] - test: improve the code in test-crypto-dh (Adrian Estrada) #10734825842c185] - test: getgroups() may contain duplicate GIDs (Sam Roberts) #10389c6618df2cc] - test: improve test stream transform constructor (Adrian Estrada) #1069951f4c8bf5c] - test: s/assert.equal/assert.strictEqual/ (Gibson Fahnestock) #10698a6bd287724] - test: use eslint to fix var->const/let (Gibson Fahnestock) #10685e6b6ce429c] - test: refactor test-http-mutable-headers.js (cjihrig) #106648262d49a44] - test: refactor cluster-preload.js (abouthiroppy) #10701fc0551072b] - test: improve test-crypto-rsa-dsa (Adrian Estrada) #10681727c5e3c96] - test: improve test-fs-write-file-sync (Adrian Estrada) #1062450130220dc] - test: s/assert.notEqual()/assert.notStrictEqual()/ (cjihrig) #1054144174a52a6] - test: refactor the code in test-util-debug.js (sivaprasanna) #10531b1c742e107] - test: improve test-fs-access (Adrian Estrada) #10542db7b27abb9] - test: refactor beforeExit tests (Rich Trott) #1058133851d1e2c] - test: fix process.title expectation (Sakthipriyan Vairamani (thefourtheye)) #10597af2bea70e0] - test: refactor test-beforeexit-event-exit.js (cjihrig) #105770a2fb0d3e1] - test: refactor several parallel/test-timer tests (Beth Griggs) #10524dba8d20ccc] - test: improve the code in test-fs-read-stream (Adrian Estrada) #10556eba9add48e] - test: refactor test-timer-close (BethGriggs) #10517dd9aefde69] - test: use const for all require() calls (cjihrig) #10550807e99b81d] - test: validate errors in test-buffer-indexof (Adrian Estrada) #1075232da59ab18] - test: fix broken assertion (cjihrig) #1084029a4d354bc] - test: refactor test-cli-eval.js (Sumit Goel) #10759a06419b045] - test: refactor test-stream2-readable-wrap.js (David Goussev) #1055155377db9b0] - test: refactor test-stream-transform-object (Rich Trott) #10588fb35ca3598] - test: test hmac binding robustness (Sam Roberts) #1092394a266e1ef] - test: refactor the code in test-fs-watch.js (sivaprasanna) #103573575f5159e] - test: reduce unmanaged parallelism in domain test (Joyee Cheung) #103297822d86ee6] - test: increase usage of assert.ifError() (cjihrig) #10543e161dcf1fc] - test: add dgram.Socket.prototype.sendto's test (abouthiroppy) #10901be3e82dbbb] - test: check error message in test-fs-make-callback (legalcodes) #1091467d97bce5a] - test: improve test-assert (richnologies) #1091669a04a9c7b] - test: increase coverage for punycode's decode (abouthiroppy) #109408778fca82b] - test: check fd 0,1,2 are used, not access mode (John Barboza) #10339e80f35c973] - test: verify shell option internals (cjihrig) #109249d5170f850] - test: fix flaky test-regress-net: make Server.prototype.unref() persistent #897 (Rich Trott) #10903c60d87b1ad] - test: don't connect to :: (use localhost instead) (Gibson Fahnestock) #10854aa4b028523] - test: improve test-fs-open-flags (Vinícius do Carmo)35d665958e] - test: increase coverage of _http_outgoing (abouthiroppy) #10820c4f16949b8] - test: add message verification on assert.throws (Travis Meisenheimer) #108905ce2ac800b] - test: refactor test-repl-tab-complete (Rich Trott) #10879999f685a69] - test: simplify array initialization (Rich Trott) #10860c77078f29f] - test: have inspector test pick an open port (Eugene Ostroukhov) #10861aa8771f842] - test: use common.hasIntl in tests related to ICU (Daijiro Wachi) #108415b38776243] - test: add http-common's test (abouthiroppy) #1083296babb2090] - test: tests for _readableStream.awaitDrain (Mark) #89147165f1d409] - test: improve the code in test-process-cpuUsage (Adrian Estrada) #10714b5c0b43efa] - test: increase test-crypto.js strictness (Rich Trott) #10784d818cfaaad] - test: improve test-fs-write-stream-throw-type (Adrian Estrada) #1077977cbc26a96] - test: delete duplicate test of noAssert in readUInt* (larissayvette) #1079136db5a663a] - test: add http_incoming's matchKnownFields test (abouthiroppy) #1081131d3a22989] - test: skip test-icu-transcode if Intl is not present (Daijiro Wachi) #107078b02b4ebb4] - test: check error msg test-writeint.js (Irene Li) #107555aad0ccefe] - test: no unused args test-fs-watch-file.js (istinson) #10758fca0da711d] - test: improve tests in pummel/test-exec (Chase Starr) #107577d917dcb27] - test: fix temp-dir option in tools/test.py (Gibson Fahnestock) #107236b54024324] - test: use realpath for NODE_TEST_DIR in common.js (Gibson Fahnestock) #10723c6aeb4491b] - test: fix linting for test-tls-add-ca-cert.js (Sam Roberts) #10771542f65c66b] - test: tls cert chain completion scenarios (Sam Roberts) #1038997a8bd20c6] - test: check tls server verification with addCACert (Sam Roberts) #10389ebcf834c14] - test: move common tls connect setup into fixtures (Sam Roberts) #1038930926ac6d6] - test: move resource intensive test to sequential (Rich Trott) #1074406a1e9eb7b] - test: add test for noAssert option in buf.read*() (larissayvette) #10713160d0381d2] - test: refactor test-crypto-padding-aes256 (adelmann) #10622cb111c96cc] - test: refactor the code of test-keep-alive.js (sivaprasanna) #10684dbb7727320] - test: validate 'expected' argument to mustCall() (Nathan Friedly) #10692e408f0a1f5] - test: fix misplaced ) in http response statuscode test (Nathan Friedly) #106924c8676bc26] - test: refactor test-doctool-html.js (abouthiroppy) #10696da572131db] - test: improve the code in test-process-hrtime (Adrian Estrada) #1066717d9a739c1] - test: refactor test-watch-file.js (sivaprasanna) #10679cf5579d746] - test: improve zlib-from-gzip-with-trailing-garbage (Michael Lefkowitz) #106742d856097b3] - test: refactor the code in test-child-process-spawn-loop.js (sivaprasanna) #106051329eb47f0] - test: allow testing uid and gid separately (cjihrig) #106474aa32c196a] - test: improve code in test-https-strict (Adrian Estrada) #10648e78de99bcb] - test: improve test-http-chunked-304 (Adrian Estrada) #10462ff23d8112a] - test: improve test-fs-readfile-zero-byte-liar (Adrian Estrada) #1057038bdfb0b8e] - test: refactor test-fs-utimes (Junshu Okamoto) #929009f35a49e3] - test: provide duration/interval to timers (Rich Trott) #947206a82436c2] - test: improve test-event-emitter-modify-in-emit (Adrian Estrada) #10600736b95a617] - test: check error and cleanups in test-fs-read-buffer (Anna Henningsen) #10611a77940c2d5] - test: mark test-tty-wrap as flaky for AIX (Michael Dawson) #10618cf875d17f3] - test: improve test-fs-null-bytes (Adrian Estrada) #10521656ba86a27] - test: fix Coverity warning in inspector test (Eugene Ostroukhov) #105109916ee8c36] - test: refactor test-https-truncate (Rich Trott) #102254ff1d3107f] - test: add http.ClientRequest defaults test (Brian White) #106541555ced404] - test, win: fix up symlink tests (Hitesh Kanwathirtha) #104774323c8018e] - test,cluster: add test-cluster-worker-deprecated (Rich Trott) #1067533af09fe6a] - test,net: add tests for server.connections (Rich Trott) #10762fc2db50021] - test,repl: add coverage for repl .clear+useGlobal (Rich Trott) #1077784bf04b0c1] - test,util: remove lint workarounds (Rich Trott) #10785c6af766ad9] - test-console: streamline arrow fn and refine regex (John Maguire) #110398fae9d4cfb] - tools: rename eslintrc to an undeprecated format (Sakthipriyan Vairamani) #7699dd5a4e1d75] - tools: update ESLint to current version (Rich Trott) #10561c92b8ecd81] - (SEMVER-MINOR) tools: add mdn link for Iterator (James M Snell) #10620dec5900c42] - tools: add lint rule to enforce timer arguments (Rich Trott) #9472891874406a] - tools: remove no-useless-regex-char-class-escape (Rich Trott) #105611634a7017e] - tools: remove custom align-function-arguments rule (Rich Trott) #1056131f8f6f768] - tools, test: require const/let in test (Gibson Fahnestock) #10685d39543e73d] - tools,doc: add Google Analytics tracking. (Phillip Johnsen) #66013adda4b2ad] - tools,test: enforce assert.ifError with lint rule (Teddy Katz) #106712bfd58adb1] - url: define @@toStringTag as a data property (Timothy Gu) #10906f1851cb8e4] - url: do not public expose inspect methods on URL (Timothy Gu) #10906b48b80f630] - url: stop exporting originFor() (Timothy Gu) #10955c0c1a4c029] - url: refactor lib/internal/url.js (Rich Trott) #109122f9fdc454f] - (SEMVER-MINOR) url: allow use of URL with http.request and https.request (James M Snell) #1063895faa55ab9] - url: check forEach callback is a function (Timothy Gu) #109053642f35d09] - url: add return value to ToUnicode/ToAscii stubs (Birunthan Mohanathas) #10893021338dc6d] - url: export URLSearchParams (Timothy Gu)5d33c96679] - url: improving URLSearchParams (Timothy Gu) #10399824978e337] - url: do not decode arbitrary %2e sequences in paths (James M Snell) #10602e46bdcf2bb] - url: change null password handling (James M Snell) #106012b01138451] - url: TupleOrigin#toString use unicode by default (Joyee Cheung) #105529f6d1f6fc2] - util: improve readability of normalizeEncoding (Joyee Cheung) #10439d628f3a227] - util: avoid out-of-bounds arguments index access (Teddy Katz) #105692641cd496d] - vm: improve performance of vm.runIn*() (Rich Trott) #10816