Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve code in test-https-strict #10648

Closed
wants to merge 1 commit into from
Closed

test: improve code in test-https-strict #10648

wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented Jan 5, 2017

  • use let and const instead of var
  • use assert.strictEqual instead of assert.equal
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 5, 2017
@mscdex mscdex added the https Issues or PRs related to the https subsystem. label Jan 5, 2017
Trott
Trott reviewed Jan 6, 2017
View reviewed changes
test/parallel/test-https-strict.js
const responseErrors = {};
let expectResponseCount = 0;
let responseCount = 0;
let pending = 0;


function server(options, port) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're refactoring: It looks like port on line 78 is unused. If that's the case, can you remove it?

@edsadr
test: improve code in test-https-strict
6d4feb0 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* remove unused var
@edsadr
Copy link
Member Author

edsadr commented Jan 6, 2017

@Trott , removed the unused var

mhdawson
mhdawson approved these changes Jan 6, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Jan 6, 2017

CI run: https://ci.nodejs.org/job/node-test-pull-request/5740/

jasnell pushed a commit that referenced this pull request Jan 9, 2017
@edsadr @jasnell
test: improve code in test-https-strict
fd11586 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* remove unused var

PR-URL: #10648
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell
Copy link
Member

jasnell commented Jan 9, 2017

Landed in fd11586

@jasnell jasnell closed this Jan 9, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@edsadr @italoacasas
test: improve code in test-https-strict
894ce3a 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* remove unused var

PR-URL: nodejs#10648
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@edsadr @italoacasas
test: improve code in test-https-strict
752db2a 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* remove unused var

PR-URL: nodejs#10648
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@edsadr @italoacasas
test: improve code in test-https-strict
2b3dab0 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* remove unused var

PR-URL: nodejs#10648
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@edsadr @italoacasas
test: improve code in test-https-strict
4aa32c1 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* remove unused var

PR-URL: nodejs#10648
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@edsadr @mhdawson @jasnell @Trott @lpinca @cjihrig @mscdex @MylesBorins @nodejs-github-bot