Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: minor cleanup in test-fs-*-buffer tests #10611

Closed
wants to merge 2 commits into from
Closed

test: minor cleanup in test-fs-*-buffer tests #10611

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jan 4, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Following up from @thefourtheye’s comments in #10593

@addaleax
test: check error in test-fs-read-buffer
a9f9aa1
@addaleax
test: cleanup test-fs-write-buffer
e101f83 
Use arrow functions and prefer `strictEqual` over `deepStrictEqual`
where it works.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 4, 2017
@addaleax addaleax added the fs Issues and PRs related to the fs subsystem / file system. label Jan 4, 2017
Trott
Trott approved these changes Jan 4, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is ✅

@addaleax
Copy link
Member Author

addaleax commented Jan 5, 2017

CI: https://ci.nodejs.org/job/node-test-commit/7047/

jasnell pushed a commit that referenced this pull request Jan 6, 2017
@addaleax @jasnell
test: check error and cleanups in test-fs-read-buffer
eab9563 
Use arrow functions and prefer `strictEqual` over `deepStrictEqual`
where it works.

PR-URL: #10611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 6, 2017

Landed in eab9563

@jasnell jasnell closed this Jan 6, 2017
@addaleax addaleax deleted the test-fs-x-buffer-cleanup branch January 9, 2017 18:20
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@addaleax @italoacasas
test: check error and cleanups in test-fs-read-buffer
7f9abb1 
Use arrow functions and prefer `strictEqual` over `deepStrictEqual`
where it works.

PR-URL: nodejs#10611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@addaleax @italoacasas
test: check error and cleanups in test-fs-read-buffer
2b5e531 
Use arrow functions and prefer `strictEqual` over `deepStrictEqual`
where it works.

PR-URL: nodejs#10611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
@addaleax @italoacasas
test: check error and cleanups in test-fs-read-buffer
13b0538 
Use arrow functions and prefer `strictEqual` over `deepStrictEqual`
where it works.

PR-URL: nodejs#10611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@addaleax @italoacasas
test: check error and cleanups in test-fs-read-buffer
736b95a 
Use arrow functions and prefer `strictEqual` over `deepStrictEqual`
where it works.

PR-URL: nodejs#10611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @jasnell @MylesBorins @thefourtheye @Trott @benjamingr @cjihrig @nodejs-github-bot