doc: change logical to bitwise OR in dns lookup #11037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR.
thefourtheye
added
dns
nodejs-github-bot
added
dns
cjihrig
approved these changes
Jan 27, 2017
TimothyGu
approved these changes
Jan 27, 2017
sam-github
approved these changes
Jan 27, 2017
lpinca
approved these changes
Jan 27, 2017
jasnell
approved these changes
Jan 27, 2017
|
Landed in 17fb1d7 |
thefourtheye
added a commit
that referenced
this pull request
Jan 30, 2017
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: #11037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 31, 2017
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: #11037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Feb 5, 2017
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: nodejs#11037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Feb 5, 2017
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: nodejs#11037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 6, 2017
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: #11037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2017
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: #11037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2017
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: #11037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hintsvalue will be a number. To specify more than one hints,their corresponding bits have to be set. So bitwise OR should be used
instead of logical OR.
Checklist
Affected core subsystem(s)
doc dns