test: increase coverage of _http_outgoing #10820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
jasnell
requested changes
Jan 15, 2017
| @@ -12,3 +12,63 @@ assert.strictEqual( | |||
| typeof ClientRequest.prototype._implicitHeader, 'function'); | |||
| assert.strictEqual( | |||
| typeof ServerResponse.prototype._implicitHeader, 'function'); | |||
|
|
|||
| // validateHeader | |||
| assert.throws(common.mustCall(() => { | |||
There was a problem hiding this comment.
There's no need to use common.mustCall() on functions passed to assert.throws()
| }), /^TypeError: Header name must be a valid HTTP Token \["undefined"\]$/); | ||
|
|
||
| assert.throws(common.mustCall(() => { | ||
| const outgoingMessage = new OutgoingMessage(); |
There was a problem hiding this comment.
To make the test more efficient, why not create a single top level outgoingMessage instance, each of the tests can just reuse it
There was a problem hiding this comment.
I'm not sure that's a good idea in this case, as the tests would be sharing state unnecessarily.
There was a problem hiding this comment.
I agree with @cjihrig's idea.
cjihrig
approved these changes
Jan 15, 2017
hiroppy
force-pushed
the
feature/add-tests-to-test-http-outgoing-proto.js
branch
from
b04af19
to
d4aaade
Compare
|
Deleted |
jasnell
approved these changes
Jan 16, 2017
targos
approved these changes
Jan 22, 2017
|
Landed in 02ccffb. Thank you! |
targos
pushed a commit
that referenced
this pull request
Jan 22, 2017
validateHeader: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L376 write: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L477 addTrailers: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L557 PR-URL: #10820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
validateHeader: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L376 write: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L477 addTrailers: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L557 PR-URL: nodejs#10820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
validateHeader: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L376 write: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L477 addTrailers: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L557 PR-URL: nodejs#10820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
validateHeader: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L376 write: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L477 addTrailers: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L557 PR-URL: nodejs#10820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
validateHeader: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L376 write: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L477 addTrailers: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L557 PR-URL: nodejs#10820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateHeader: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L376
write: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L477
addTrailers: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L557
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test