url: stop exporting originFor()

[TimothyGu]

In #10800, the utility of url.originFor() was discussed, and it was tentatively established that the function is not as useful as it might appear at first.

I'm still open to more discussions either on that issue or here, and this PR is just created to get things moving and to show how a removal can look like.

Fixes: #10800

/cc @nodejs/url

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

url

[jasnell]

I'm -1 on the full range of changes here. For now we can simply not export originFor in lib/url.js.

[TimothyGu]

@jasnell, changed.

[TimothyGu]

CI: https://ci.nodejs.org/job/node-test-pull-request/5987/

[joyeecheung]

If origin.inspect is no longer tested then maybe origin.inspect can be removed?

[TimothyGu]

@joyeecheung, that was what I had at first (along with a change that removed unnecessary symbols), but @jasnell objected to it.

[joyeecheung]

Not sure if we should leave untested code floating around, but LGTM anyway.

[jasnell]

I'd like it to remain for now because I may have use for it. I need to finish up a few other things before I'll get back to that, however, so I'd like for it to stay in the meantime

[TimothyGu]

I'll land this tomorrow if there are no objections.

[joyeecheung]

@TimothyGu I think probably you need to consult @jasnell first whether he doesn't need this anymore? (from #10955 (comment))

[TimothyGu]

@joyeecheung, I believe he was not referring to the originFor() function (after all, he did approve of this PR), but rather your comment about unused code.

[joyeecheung]

@TimothyGu Oh right, I was confused about the "it"..in that case this is ready to land! Sorry about the confusion.

[TimothyGu]

One last CI: https://ci.nodejs.org/job/node-test-pull-request/6078/

[TimothyGu]

Landed in e71c278.