Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor the code in test/pummel/test-child-process-spawn-loop.js #10605

Closed
wants to merge 1 commit into from
Closed

test: refactor the code in test/pummel/test-child-process-spawn-loop.js #10605

wants to merge 1 commit into from

Conversation

sivaprs
Copy link
Contributor

@sivaprs sivaprs commented Jan 4, 2017

  • use const and let instead of var
  • use assert.strictEqual instead of assert.equal
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

change description:

  • use const and let instead of var
  • use assert.strictEqual instead of assert.equal
  • use arrow functions

@sivaprs
test: refactor the code in test/pummel/test-child-process-spawn-loop.js
15a1fea 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 4, 2017
@sivaprs
Copy link
Contributor Author

sivaprs commented Jan 4, 2017

cc: @thefourtheye

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Jan 4, 2017
thefourtheye
thefourtheye reviewed Jan 4, 2017
View reviewed changes
test/pummel/test-child-process-spawn-loop.js

function doSpawn(i) {
var child = spawn('python', ['-c', 'print ' + SIZE + ' * "C"']);
var count = 0;
const child = spawn('python', ['-c', 'print ' + SIZE + ' * "C"']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/testing This test depends on python, although I understand that our build system depends on it. Is that okay to keep it as it is, or refactor it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to keep the dependency here but it's also reasonable to spawn Node instead. I don't want to block this PR on it though.

benjamingr
benjamingr approved these changes Jan 4, 2017
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but I'm still +0 on such PRs.

@jasnell
Copy link
Member

jasnell commented Jan 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5728/

jasnell pushed a commit that referenced this pull request Jan 9, 2017
@sivaprs @jasnell
test: refactor the code in test-child-process-spawn-loop.js
41567ee 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: #10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 9, 2017

Landed in 41567ee

@jasnell jasnell closed this Jan 9, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@sivaprs @italoacasas
test: refactor the code in test-child-process-spawn-loop.js
088c734 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: nodejs#10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@sivaprs @italoacasas
test: refactor the code in test-child-process-spawn-loop.js
e83d626 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: nodejs#10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@sivaprs @italoacasas
test: refactor the code in test-child-process-spawn-loop.js
9510536 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: nodejs#10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@sivaprs @italoacasas
test: refactor the code in test-child-process-spawn-loop.js
2d85609 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: nodejs#10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@sivaprs @MylesBorins
test: refactor the code in test-child-process-spawn-loop.js
166ac14 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: #10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@sivaprs @MylesBorins
test: refactor the code in test-child-process-spawn-loop.js
cd5b561 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: #10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@sivaprs @MylesBorins
test: refactor the code in test-child-process-spawn-loop.js
3135455 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: #10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@sivaprs @MylesBorins
test: refactor the code in test-child-process-spawn-loop.js
4453c0c 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: #10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefourtheye thefourtheye thefourtheye left review comments

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sivaprs @jasnell @thefourtheye @benjamingr @mscdex @MylesBorins @nodejs-github-bot