benchmark: keep decimals in results #10559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jan 3, 2017
|
I'm +1 on the suggestion but I find the regexp kind of hard to read. (Not blocking or anything, just pointing it out) |
Some benchmarks' results are small values, so keeping decimals when running them manually (not comparing) can be helpful. PR-URL: nodejs#10559 Reviewed-By: James M Snell <jasnell@gmail.com>
mscdex
force-pushed
the
benchmark-keep-decimals
branch
from
b03c096 to
7889416
Compare
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Some benchmarks' results are small values, so keeping decimals when running them manually (not comparing) can be helpful. PR-URL: nodejs#10559 Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
Some benchmarks' results are small values, so keeping decimals when running them manually (not comparing) can be helpful. PR-URL: nodejs#10559 Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
Some benchmarks' results are small values, so keeping decimals when running them manually (not comparing) can be helpful. PR-URL: nodejs#10559 Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
Some benchmarks' results are small values, so keeping decimals when running them manually (not comparing) can be helpful. PR-URL: nodejs#10559 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
|
this is not landing cleanly on LTS. Should it be backported? Add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some benchmarks' results are small values, so keeping decimals when running them manually (not comparing) can be helpful.
Lint: https://ci.nodejs.org/job/node-test-linter/6124/Lint: https://ci.nodejs.org/job/node-test-linter/6125/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)