Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve code in test-fs-write-file-sync #10624

Closed
wants to merge 1 commit into from
Closed

test: improve code in test-fs-write-file-sync #10624

wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented Jan 5, 2017

  • use let and const instead of var
  • use assert.strictEqual instead of assert.equal
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added dont-land-on-v7.x test Issues and PRs related to the tests. labels Jan 5, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Jan 5, 2017
lpinca
lpinca reviewed Jan 5, 2017
View reviewed changes
test/parallel/test-fs-write-file-sync.js

fs.writeFileSync(file1, '123', {mode: mode});

content = fs.readFileSync(file1, {encoding: 'utf8'});
assert.equal('123', content);
assert.strictEqual('123', content);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please swap the arguments here and throughout the rest of the file?

mhdawson
mhdawson approved these changes Jan 5, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to fixing nit mentioned by last reviewer

@edsadr edsadr force-pushed the fs-write-file-sync branch from c4de8c6 to f56a1c3 Compare January 5, 2017 21:44
@edsadr
Copy link
Member Author

edsadr commented Jan 5, 2017

@lpinca , @mhdawson ... did the nit

lpinca
lpinca reviewed Jan 7, 2017
View reviewed changes
test/parallel/test-fs-write-file-sync.js

assert.equal(mode, fs.statSync(file1).mode & 0o777);
assert.strictEqual(mode, fs.statSync(file1).mode & 0o777);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you also please swap the arguments here?

@edsadr
test: improve code in test-fs-write-file-sync
7de6d49 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard
@edsadr edsadr force-pushed the fs-write-file-sync branch from f56a1c3 to 7de6d49 Compare January 7, 2017 14:58
@edsadr
Copy link
Member Author

edsadr commented Jan 7, 2017

@lpinca, changed those

@lpinca
Copy link
Member

lpinca commented Jan 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5751/

@lpinca
Copy link
Member

lpinca commented Jan 7, 2017

Landed in 8a12368.

@lpinca lpinca closed this Jan 7, 2017
lpinca pushed a commit that referenced this pull request Jan 7, 2017
@edsadr @lpinca
test: improve test-fs-write-file-sync
8a12368 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@edsadr @italoacasas
test: improve test-fs-write-file-sync
5763899 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@edsadr @italoacasas
test: improve test-fs-write-file-sync
a7e57d6 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@edsadr @targos
test: improve test-fs-write-file-sync
66309eb 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr @italoacasas
test: improve test-fs-write-file-sync
727c5e3 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr @italoacasas
test: improve test-fs-write-file-sync
c978c45 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell
Copy link
Member

jasnell commented Mar 8, 2017

This will need a backport PR to land on v4

jasnell pushed a commit that referenced this pull request Mar 8, 2017
@edsadr @jasnell
test: improve test-fs-write-file-sync
6e8ae7f 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@edsadr @MylesBorins
test: improve test-fs-write-file-sync
04dc1cd 
* use let and const instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10624
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@edsadr @lpinca @jasnell @cjihrig @mhdawson @mscdex @nodejs-github-bot