test: testing noAssert in buffer.write() #10790
Conversation
nodejs-github-bot
added
test
You should be able to run these tests for those functions as well. The issue with those functions will only manifest if you request something out of range. Since this test requests valid ranges with |
larissayvette
force-pushed
the
test-write
branch
from
b174d57
to
16573ab
Compare
|
@Trott included those test cases |
|
|
||
| assert.throws( | ||
| () => Buffer.alloc(-1)[funx](0), | ||
| /^RangeError: "size" argument must not be negative$/ |
There was a problem hiding this comment.
This functionality is tested every time. Wouldn't it be enough to test this only once?
There was a problem hiding this comment.
Oh, yes, that's testing the wrong thing. It should test a legit alloc() call and an out-of-range call to the write function being tested. @larissayvette can you adjust it?
larissayvette
force-pushed
the
test-write
branch
from
16573ab
to
1c69e01
Compare
|
Changes LGTM |
|
Single failure on SmartOS is unrelated, opened an issue for it. |
Add test to cover previously untested `noAssert` functionality in buf.write*() functions. PR-URL: nodejs#10790 Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 084acc8. |
Add test to cover previously untested `noAssert` functionality in buf.write*() functions. PR-URL: #10790 Reviewed-By: Rich Trott <rtrott@gmail.com>
Add test to cover previously untested `noAssert` functionality in buf.write*() functions. PR-URL: #10790 Reviewed-By: Rich Trott <rtrott@gmail.com>
|
This would need a backport PR to land in v4 |
Add test to cover previously untested `noAssert` functionality in buf.write*() functions. PR-URL: #10790 Reviewed-By: Rich Trott <rtrott@gmail.com>
Checklist
Affected core subsystem(s)
test
Test for
noAssertin buffer.write() files and inludedbuffer.writeDouble*andbuffer.writeFloat*as it was not present in the first commit