timers, errors: migrate to internal/errors.js #11384
Conversation
nodejs-github-bot
added
errors
jasnell
added
the
semver-major
| } | ||
|
|
||
| if (msecs < 0 || !isFinite(msecs)) { | ||
| throw new RangeError('"msecs" argument must be ' + | ||
| throw new errors.RangeError('ERR_INVALID_ARG_TYPE', 'msecs', | ||
| 'a non-negative finite number'); |
There was a problem hiding this comment.
hmm.. will have to think about this one because the error message is not going to format that well.
There was a problem hiding this comment.
We could have separate error statements for non-finite and negative numbers
There was a problem hiding this comment.
Yeah. It would be a separate error code but that's workable
There was a problem hiding this comment.
Yeah. It would be a separate error code but that's workable
There was a problem hiding this comment.
Oh, I misunderstood the discussion, it was about throwing different errors for <0 and isFinite, sorry. Anyway I still think there should be something like ERR_NEGATIVE_ARG
There was a problem hiding this comment.
@shubheksha do you want to take a stab at addressing @joyeecheung 's comment? Thanks!
|
Blocked by #11580. |
ChALkeR
added
blocked
|
#11580 landed, unblocking. |
|
@shubheksha Do you want to rebase this so we can pick this up again? Sorry for dragging it out for so long. Hope you're still interested in working on this! |
Replaced function definitions with arrow functions where possible
|
I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed. |
|
Hey @fhinkel, I did rebase this. |
|
It seems like these errors were already migrated at some point. I am closing this therefore. @shubheksha I am sorry that your PR could not land and your work is much appreciated nevertheless! |
Fixes #11273
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
timers, errors, test