-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: depend on python2 specifically #11397
Conversation
This solves the problem of not being able to build node on system where both python2 and python3 is installed and python3 is the default.
Hrmm... I'm curious if there are any modern platforms/distributions that only provide |
none that i'm aware of (but i'm no expert)... but, imho, at least on linux, the good practice is to have python2 and/or python3 and python being just symlink to one of those... |
I think this have been brought up previously. There are too many ways python(2) is installed; I think we shouldn't rock the boat on this one. @bnoordhuis thoughts? |
I do not have |
FWIW:
I have only Python 2.7.13 on Windows 7 x64. Would python2 appear if I install Python 3x? |
Yes, this is the clincher. OS X systems don't have a python2 binary. |
Given the above, I think that #11375 is a better solution to this problem. |
hmm, just found this. ...adding for reference: #9512 |
As #11375 has landed and this is not going to fully work I am going to close this. If you feel that it should be reopened, please do so. |
This solves the problem of not being able to build node on system
where both python2 and python3 is installed and python3 is the
default.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
build system
...i will send patches for "dep" and "tools" to their respective upstream but this solves the problem for the node part.