Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: suggest python2 command in configure #11375

Closed
wants to merge 1 commit into from
Closed

tools: suggest python2 command in configure #11375

wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

As suggested by @jbergstroem, this text should be helpful to people on systems where python is python3. Will print:

Please use either Python 2.6 or 2.7
You can try using a different interpreter like this:

  PYTHON=/usr/bin/python2 ./configure

Ref: #9512 (comment)

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 14, 2017
@silverwind
Copy link
Contributor Author

silverwind commented Feb 14, 2017 •
edited
Loading

Changed it so it suggests a direct call using a found python 2 binary. For example:

Please use either Python 2.6 or 2.7:

   /usr/local/bin/python2 configure

If none is found, will print

Please use either Python 2.6 or 2.7

@silverwind silverwind changed the title tools: add python version help text to configure tools: suggest python2 command in configure Feb 14, 2017
@silverwind
Copy link
Contributor Author

silverwind commented Feb 14, 2017 •
edited
Loading

Squashed and updated commit title.

@silverwind
tools: suggest python2 command in configure
9d80a26 
Try and find a suitable python2 binary and suggest it to the user in
case they start the configure script with a incompatible version.
@gibfahn gibfahn mentioned this pull request Feb 16, 2017
Closed
2 tasks
@silverwind silverwind mentioned this pull request Feb 16, 2017
Closed
@silverwind
Copy link
Contributor Author

Landed in 25e803e.

@silverwind silverwind closed this Feb 16, 2017
@silverwind silverwind deleted the configure-python-print branch February 16, 2017 22:28
silverwind added a commit that referenced this pull request Feb 16, 2017
@silverwind
tools: suggest python2 command in configure
25e803e 
Try and find a suitable python2 binary and suggest it to the user in
case they start the configure script with a incompatible version.

PR-URL: #11375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 20, 2017
@silverwind @italoacasas
tools: suggest python2 command in configure
9432b96 
Try and find a suitable python2 binary and suggest it to the user in
case they start the configure script with a incompatible version.

PR-URL: nodejs#11375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
@silverwind @italoacasas
tools: suggest python2 command in configure
5b5dca9 
Try and find a suitable python2 binary and suggest it to the user in
case they start the configure script with a incompatible version.

PR-URL: #11375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@silverwind @jasnell
tools: suggest python2 command in configure
c74fa1b 
Try and find a suitable python2 binary and suggest it to the user in
case they start the configure script with a incompatible version.

PR-URL: #11375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@silverwind @jasnell
tools: suggest python2 command in configure
936d6f2 
Try and find a suitable python2 binary and suggest it to the user in
case they start the configure script with a incompatible version.

PR-URL: #11375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@silverwind @MylesBorins
tools: suggest python2 command in configure
b38d8d6 
Try and find a suitable python2 binary and suggest it to the user in
case they start the configure script with a incompatible version.

PR-URL: #11375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@silverwind @MylesBorins
tools: suggest python2 command in configure
8f49962 
Try and find a suitable python2 binary and suggest it to the user in
case they start the configure script with a incompatible version.

PR-URL: #11375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @jasnell @Fishrock123 @cjihrig @gibfahn @nodejs-github-bot