Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.7.0 Proposal #11553

Merged
merged 164 commits into from
Mar 1, 2017
Merged

7.7.0 Proposal #11553

merged 164 commits into from
Mar 1, 2017

Conversation

italoacasas
Copy link
Contributor

@italoacasas italoacasas commented Feb 25, 2017 •
edited
Loading

2017-28-02, Version 7.7.0 (Current), @italoacasas

This release contains a deprecation warning for node --debug. You can find more information in the
Diagnostics Working Group Update

Notables changes

  • child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig) #11288
  • http: new functions to access the headers for an outgoing HTTP message (Brian White) #11562
  • lib: deprecate node --debug at runtime (Josh Gavant) #11275
  • tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts) #11005
  • url: adding URL.prototype.toJSON support (Michaël Zasso) #11236
  • doc: items in the API documentation may now have changelogs (Anna Henningsen) #11489
  • crypto: adding support for OPENSSL_CONF again (Sam Roberts) #11006
  • src: adding support for trace-event tracing (misterpoe) #11106

Commits

DavidCai1111 and others added 30 commits February 21, 2017 21:14
@DavidCai1111 @italoacasas
test: increase coverage of buffer
66081d1 
PR-URL: #11312
Backport-of: #11122
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@italoacasas
deps: cherry-pick 7c982e7 from V8 upstream
d4000e7 
Original commit message:

    PPC/s390: [Turbofan]: Use new MachineTypes in access-builder.

    Port 56429fc14671a10749190a4dfeacd38b7270f6f5

    Original Commit Message:

        Introduced MachineType::TaggedSigned() and TaggedPointer().

        The idea is to quit using the representational dimension of Type, and
        instead encode this information in the MachineRepresentation (itself
        lightly wrapped in MachineType, along with MachineSemantic).

        There are three parts to the whole change:

        1) Places that set the machine representation - constant nodes, loads nad
           stores, global object and native context specialization.

        2) Places that propagate type/representation - this is representation
           inference (aka simplified lowering). At the end of this process we
           expect to have a MachineRepresentation for every node. An interesting
           part of this is phi merging.

        3) Places that examine representation - WriteBarrier elimination does this.
           Currently it's looking at the Type representation dimension, but as
           a part of this change (or in a soon-to-follow change) it can simply
           examine the MachineRepresentation.

    R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
    BUG=
    LOG=N

    Review-Url: https://codereview.chromium.org/2662223003
    Cr-Commit-Position: refs/heads/master@{#42817}

PR-URL: #11263
Backport-of: v8/v8@7c982e7
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@cjihrig @italoacasas
child_process: exit spawnSync with null on signal
58e2517 
This commit sets the spawnSync() exit code to null when the
child is killed via signal. This brings the behavior more in
sync with spawn().

Fixes: #11284
PR-URL: #11288
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@cjihrig @italoacasas
test: cover dgram socket close during cluster bind
e7978f0 
When a non-exclusive dgram socket is bound from a cluster
worker, it attempts to get a handle from the cluster module.
This commit adds coverage for the case where the socket is
closed while querying the cluster module for a handle.

PR-URL: #11292
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis @italoacasas
src: remove unused typedef
8a5c0fb 
Seems to have been overlooked in commit dd93c53 ("Make node::DLOpen use
uv_dlopen") from 2011.

PR-URL: #11322
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@vsemozhetbyt @italoacasas
doc: update code examples in domain.md
6a45265 
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jBarz @italoacasas
timer,domain: maintain order of timer callbacks
506a1cb 
PR-URL: #10522
Fixes: #1271
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@vsemozhetbyt @italoacasas
doc: synchronize + update _toc.md and all.md
4d7c942 
PR-URL: #11206
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@akito0107 @italoacasas
test: improve crypto coverage
348f2ef 
* call Certificate function directly
* check exception when sign option is undefined

PR-URL: #11280
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung @italoacasas
benchmark: move url data to fixtures
7a3553f 
PR-URL: #11264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@joyeecheung @italoacasas
benchmark: refactor whatwg-url-properties
678ea11 
PR-URL: #11264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell @italoacasas
dns: avoid use of arguments
662b0c3 
PR-URL: #11359
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com
@jasnell @italoacasas
tls: avoid potentially deoptimizing use of arguments
5f94ff6 
Replace use of arguments with `...args`

```
 tls/tls-connect.js dur=5 concurrency=1      -9.43 %            0.172136744
 tls/tls-connect.js dur=5 concurrency=10     29.05 %         ** 0.001108115
```

PR-URL: #11357
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@cjihrig @italoacasas
src: remove unused variable in node_crypto
7d47f27 
env was unused since the ref'd commit

Ref: e34ee1d
PR-URL: #11361
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@Trott @italoacasas
assert: unlock the assert API
0762482 
Change the Stability Index on `assert` from Locked to Stable.

PR-URL: #11304
Ref: #11200
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell @italoacasas
buffer: avoid use of arguments
d08a8e6 
Avoid use of arguments in Buffer.prototype.toString()

PR-URL: #11358
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell @italoacasas
buffer: refactor slowToString
4ffad09 
Since slowToString only has one callsite, refactor to eliminate
the use of call.

PR-URL: #11358
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott @italoacasas
assert: remove unneeded condition
6a2f330 
PR-URL: #11314
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Trott @italoacasas
test: refactor test-tls-cert-chains-in-ca
f495389 
When splitting PEM string into separate certs, use non-capturing regexp
to avoid having to put the split string back with .map(). As a bonus,
this splits the PEM into two certs, rather than 2 certs and a third
crufty whitespace-only string.

PR-URL: #11367
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@bnoordhuis @italoacasas
src: make copies of startup environment variables
96a6d64 
Mutations of the environment can invalidate pointers to environment
variables, so make `secure_getenv()` copy them out instead of returning
pointers.

PR-URL: #11051
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@bnoordhuis @italoacasas
src: make --icu-data-dir= switch testable
73e316e 
Move some code around so we can properly test whether the switch
actually does anything.

PR-URL: #11255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@bnoordhuis @italoacasas
src: fix --icu-data-dir= regression
a8613f8 
Commit a8734af ("src: make copies of startup environment variables")
from two weeks ago introduced a regression in the capturing of the
`--icu-data-dir=` switch: it captured the string up to the `=` instead
of what comes after it.

PR-URL: #11255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@sam-github @italoacasas
src: add SafeGetenv() to internal API
8be6702 
Allow it to be used anywhere in src/ that env variables with security
implications are accessed.

PR-URL: #11006
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@sam-github @italoacasas
crypto: support OPENSSL_CONF again
570c5e1 
A side-effect of https://github.com/nodejs/node-private/pull/82
was to remove support for OPENSSL_CONF, as well as removing the default
read of a configuration file on startup.

Partly revert this, allowing OPENSSL_CONF to be used to specify a
configuration file to read on startup, but do not read a file by
default.

If the --openssl-config command line option is provided, its value is
used, not the OPENSSL_CONF environment variable.

Fix: #10938
PR-URL: #11006
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@joyeecheung @italoacasas
test, url: synchronize WPT url tests
7aaa960 
* attributon of WPT in url-setter-tests
* add WPT test utilities
* synchronize WPT URLSearchParams tests
* synchronize WPT url tests
* split whatwg-url-inspect test
* port historical url tests from WPT
* protocol setter and special URLs

Refs: web-platform-tests/wpt#4413
Refs: whatwg/url#104
Backport-of: #11079
@jasnell @italoacasas
doc: add documentation for url.format(URL[, options]);
5a2db15 
Backport-of: #10857
@TimothyGu @italoacasas
url: add urlSearchParams.sort()
c25c16c 
Backport-of: #11098
Fixes: #10760
Ref: whatwg/url#26
Ref: whatwg/url#199
Ref: web-platform-tests/wpt#4531
@TimothyGu @italoacasas
benchmark: add url/url-searchparams-sort.js
7e37628 
Backport-of: #11098
@TimothyGu @italoacasas
url: fix surrogate handling in encodeAuth()
8dbd562 
Also factor out common parts in querystring and url.

Backport-of: #11161
@joyeecheung @italoacasas
benchmark: clean up legacy url benchmarks
5a81031 
Backport-of: #11264
@italoacasas
doc: adding deprecations.md
1c7f221 
PR-URL: #11621
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@misterpoe @italoacasas
src: add tracing controller
bd4ccc8 
This commit adds support for trace-event tracing to Node.js. It provides
a mechanism to centralize tracing information generated by V8, Node
core, and userspace code. It includes:

 - A trace writer responsible for serializing traces and cycling the
   output files so that no individual file becomes to large.
 - A buffer for aggregating traces to allow for batched flushes.
 - An agent which initializes the tracing controller and ensures that
   trace serialization is done on a separate thread.
 - A set of macros for generating trace events.
 - Tests and documentation.

Author: Raymond Kang <raymondksi@gmail.com>
Author: Kelvin Jin <kelvinjin@google.com>
Author: Matthew Loring <mattloring@google.com>
Author: Jason Ginchereau <jasongin@microsoft.com>

PR-URL: #11106
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
@italoacasas
2017-02-28, Version 7.7.0 (Current)
a7ffa8d 
Notables changes:

* child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
[#11288](#11288)
* http: new functions to access the headers for an outgoing HTTP message (Brian White)
[#11562](#11562)
* lib: deprecate node --debug at runtime (Josh Gavant)
[#11275](#11275)
* tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
[#11005](#11005)
* url: adding URL.prototype.toJSON support (Michaël Zasso)
[#11236](#11236)
* doc: items in the API documentation may now have changelogs (Anna Henningsen)
[#11489](#11489)
* crypto: adding support for OPENSSL_CONF again (Sam Roberts)
[#11006](#11006)
* src: adding support for trace-event tracing (misterpoe)
[#11106](#11106)

PR-URL: #11553
@italoacasas italoacasas merged commit a7ffa8d into v7.x Mar 1, 2017
italoacasas added a commit that referenced this pull request Mar 1, 2017
@italoacasas
Working on v7.7.1
9c75f4c 
PR-URL: #11553
italoacasas added a commit to italoacasas/node that referenced this pull request Mar 1, 2017
@italoacasas
2017-02-28, Version 7.7.0 (Current)
abc13e5 
Notables changes:

* child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
[nodejs#11288](nodejs#11288)
* http: new functions to access the headers for an outgoing HTTP message (Brian White)
[nodejs#11562](nodejs#11562)
* lib: deprecate node --debug at runtime (Josh Gavant)
[nodejs#11275](nodejs#11275)
* tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
[nodejs#11005](nodejs#11005)
* url: adding URL.prototype.toJSON support (Michaël Zasso)
[nodejs#11236](nodejs#11236)
* doc: items in the API documentation may now have changelogs (Anna Henningsen)
[nodejs#11489](nodejs#11489)
* crypto: adding support for OPENSSL_CONF again (Sam Roberts)
[nodejs#11006](nodejs#11006)
* src: adding support for trace-event tracing (misterpoe)
[nodejs#11106](nodejs#11106)

PR-URL: nodejs#11553
italoacasas added a commit to italoacasas/nodejs.org that referenced this pull request Mar 1, 2017
@italoacasas
blog: release post for v7.7.0
06e1365 
PR-URL: nodejs/node#11553
@italoacasas italoacasas mentioned this pull request Mar 1, 2017
Merged
cjihrig pushed a commit to nodejs/nodejs.org that referenced this pull request Mar 1, 2017
@italoacasas @cjihrig
blog: release post for v7.7.0
8a15ba4 
PR-URL: nodejs/node#11553
italoacasas added a commit to italoacasas/node that referenced this pull request Mar 1, 2017
@italoacasas
2017-02-28, Version 7.7.0 (Current)
15e7028 
Notables changes:

* child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
[nodejs#11288](nodejs#11288)
* http: new functions to access the headers for an outgoing HTTP message (Brian White)
[nodejs#11562](nodejs#11562)
* lib: deprecate node --debug at runtime (Josh Gavant)
[nodejs#11275](nodejs#11275)
* tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
[nodejs#11005](nodejs#11005)
* url: adding URL.prototype.toJSON support (Michaël Zasso)
[nodejs#11236](nodejs#11236)
* doc: items in the API documentation may now have changelogs (Anna Henningsen)
[nodejs#11489](nodejs#11489)
* crypto: adding support for OPENSSL_CONF again (Sam Roberts)
[nodejs#11006](nodejs#11006)
* src: adding support for trace-event tracing (misterpoe)
[nodejs#11106](nodejs#11106)

PR-URL: nodejs#11553
italoacasas added a commit to italoacasas/node that referenced this pull request Mar 1, 2017
@italoacasas
Working on v7.7.1
9b8cac8 
PR-URL: nodejs#11553
@MylesBorins
Copy link
Contributor

I want to mention that we don't really have a documented convention on the proposal branch name... do we want to standardize? I'm not convinced it is necessary unless we plan to build tooling around it

@sam-github
Copy link
Contributor

@MylesBorins It makes a difference to humans looking at the repo branches, and the branches aren't ephemeral, they stick around, like the tags do. It looks like everyone chose to use the same naming convention, pretty much, so docing the convention isn't onerous.

@evanlucas
Copy link
Contributor

@sam-github the branches are supposed to be deleted

@sam-github
Copy link
Contributor

@evanlucas hm, they have not been, at least not all, this one isn't, nor are the ones in #11553 (comment)

If the branch names are ephemeral, I care less, though again, I'm not here to mindlessly nit pick, I guessed the branch name based on all the other ones, didn't find it, and had to go looking, so having a naming convention would have saved me a minute or two. nbd.

imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017
@imyller
2017-02-28, Version 7.7.0 (Current)
8257528 
    Notables changes:

    * child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
    [#11288](nodejs/node#11288)
    * http: new functions to access the headers for an outgoing HTTP message (Brian White)
    [#11562](nodejs/node#11562)
    * lib: deprecate node --debug at runtime (Josh Gavant)
    [#11275](nodejs/node#11275)
    * tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
    [#11005](nodejs/node#11005)
    * url: adding URL.prototype.toJSON support (Michaël Zasso)
    [#11236](nodejs/node#11236)
    * doc: items in the API documentation may now have changelogs (Anna Henningsen)
    [#11489](nodejs/node#11489)
    * crypto: adding support for OPENSSL_CONF again (Sam Roberts)
    [#11006](nodejs/node#11006)
    * src: adding support for trace-event tracing (misterpoe)
    [#11106](nodejs/node#11106)

    PR-URL: nodejs/node#11553

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@sam-github sam-github deleted the 7.7.0-proposal branch March 6, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu left review comments

Assignees

@italoacasas italoacasas

Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.