test: use expectsError in test-debug-agent.js #11410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use common.expectsError() in place of inline validation function in test-debug-agent.js.
hiroppy
added
the
errors
mscdex
added
debugger
errors
jasnell
approved these changes
Feb 16, 2017
cjihrig
approved these changes
Feb 16, 2017
targos
approved these changes
Feb 18, 2017
|
Landed in ca37ec0 |
targos
pushed a commit
that referenced
this pull request
Feb 18, 2017
Use common.expectsError() in place of inline validation function in test-debug-agent.js. PR-URL: #11410 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
yay! thanks, first [landed] contribution! :−) |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 25, 2017
Use common.expectsError() in place of inline validation function in test-debug-agent.js. PR-URL: nodejs#11410 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use common.expectsError() in place of inline validation function in
test-debug-agent.js.
like #11409 #11408
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test errors debugger