tty: avoid oob warning in TTYWrap::GetWindowSize() #11454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 18, 2017
jasnell
approved these changes
Feb 19, 2017
|
@reklatsmasters could you make sure the commit message first line is no more than 50 characters long? :D (looks like it might be over?) |
reklatsmasters
changed the title
|
@Fishrock123 Ok, replaced |
|
Landed in 3f02b47 (with the commit message title set to the changed PR title here). Thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
PR-URL: #11454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
PR-URL: #11454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #11454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #11454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #11454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #11454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we run node with flag
--trace_array_abuse, we will see many warnings likeThese logs generated by
CheckArrayAbuse. If we set envNODE_DEBUG, we get these messages forttymodule. Other warnings generated from process.binding and StackPushStep to reproduce:
NODE_DEBUG=module node --trace_array_abuse -e ''Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tty