Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, url: sync WPT url test data #11439

Closed
wants to merge 4 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Feb 17, 2017

This PR synchronize url-tests.json with upstream urltestdata and rename it to a js file so we can comment out incompatible test cases and be aware of them.

url-tests-additional.js now is a placeholder since existing test cases have been upstreamed by web-platform-tests/wpt#4693. There are other PRs adding data to it, so we can keep this as a temporary place for test cases not upstreamed yet.

@nodejs/url

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url-whatwg, test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 17, 2017
@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Feb 17, 2017
@TimothyGu
Copy link
Member

@joyeecheung
Copy link
Member Author

arm failure is actually green

joyeecheung added a commit that referenced this pull request Feb 21, 2017
Make url-tests a js file so we can comment out
incompatible tests

PR-URL: #11439
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Feb 21, 2017
Synchronize url-tests to upstream b207902 and
comment out incompatible tests

PR-URL: #11439
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Feb 21, 2017
url-tests-additional.js now is a placeholder since existing test cases
have been upstreamed. This is now a temporary place for test cases
not upstreamed yet.

Refs: web-platform-tests/wpt#4693
PR-URL: #11439
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung
Copy link
Member Author

Landed in 3e6f103...84ee957. Thanks!

italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
Make url-tests a js file so we can comment out
incompatible tests

PR-URL: nodejs#11439
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
Synchronize url-tests to upstream b207902 and
comment out incompatible tests

PR-URL: nodejs#11439
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
url-tests-additional.js now is a placeholder since existing test cases
have been upstreamed. This is now a temporary place for test cases
not upstreamed yet.

Refs: web-platform-tests/wpt#4693
PR-URL: nodejs#11439
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants