test, url: sync WPT url test data #11439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
added
the
whatwg-url
targos
approved these changes
Feb 18, 2017
TimothyGu
approved these changes
Feb 18, 2017
|
arm failure is actually green |
jasnell
approved these changes
Feb 19, 2017
joyeecheung
added a commit
that referenced
this pull request
Feb 21, 2017
Make url-tests a js file so we can comment out incompatible tests PR-URL: #11439 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung
added a commit
that referenced
this pull request
Feb 21, 2017
url-tests-additional.js now is a placeholder since existing test cases have been upstreamed. This is now a temporary place for test cases not upstreamed yet. Refs: web-platform-tests/wpt#4693 PR-URL: #11439 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 3e6f103...84ee957. Thanks! |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 25, 2017
Make url-tests a js file so we can comment out incompatible tests PR-URL: nodejs#11439 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 25, 2017
Synchronize url-tests to upstream b207902 and comment out incompatible tests PR-URL: nodejs#11439 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 25, 2017
url-tests-additional.js now is a placeholder since existing test cases have been upstreamed. This is now a temporary place for test cases not upstreamed yet. Refs: web-platform-tests/wpt#4693 PR-URL: nodejs#11439 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR synchronize url-tests.json with upstream urltestdata and rename it to a js file so we can comment out incompatible test cases and be aware of them.
url-tests-additional.js now is a placeholder since existing test cases have been upstreamed by web-platform-tests/wpt#4693. There are other PRs adding data to it, so we can keep this as a temporary place for test cases not upstreamed yet.
@nodejs/url
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url-whatwg, test