Upstream Node.js URL test data #4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying @Sebmaster, @domenic, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) These tests will be available shortly on w3c-test.org. w3c-test:do-not-mirror (What's this?) |
|
The second commit added expected origins(need more thorough reviews), currently Node.js is unable to produce these expected origins either. |
domenic
requested changes
Feb 1, 2017
There was a problem hiding this comment.
The URL parsing looks good; the origins should all be the string "null" per https://url.spec.whatwg.org/#origin "Otherwise" + https://html.spec.whatwg.org/multipage/browsers.html#unicode-serialisation-of-an-origin step 1
joyeecheung
force-pushed
the
nodejs-urltestdata
branch
from
f930654 to
81329e4
Compare
|
Ah, forgot these schemes should've resulted int opaque origins. Thanks, I've updated them to |
domenic
approved these changes
Feb 1, 2017
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Feb 1, 2017
3 tasks
joyeecheung
added a commit
to nodejs/node
that referenced
this pull request
Feb 21, 2017
url-tests-additional.js now is a placeholder since existing test cases have been upstreamed. This is now a temporary place for test cases not upstreamed yet. Refs: web-platform-tests/wpt#4693 PR-URL: #11439 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 25, 2017
url-tests-additional.js now is a placeholder since existing test cases have been upstreamed. This is now a temporary place for test cases not upstreamed yet. Refs: web-platform-tests/wpt#4693 PR-URL: nodejs#11439 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#11079
cc @domenic