Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enhance test-common.js #11433

Closed
wants to merge 1 commit into from
Closed

test: enhance test-common.js #11433

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 16, 2017

  • refactor test-common.js so that global leak detection does not need to
    be disabled
  • add test for common.fail()
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

* refactor test-common.js so that global leak detection does not need to
  be disabled
* add test for common.fail()
@Trott Trott added the test Issues and PRs related to the tests. label Feb 16, 2017
@mscdex
Copy link
Contributor

mscdex commented Feb 17, 2017

Perhaps we should also add a test or two for common.mustNotCall()?

@targos
Copy link
Member

targos commented Feb 18, 2017

jasnell pushed a commit that referenced this pull request Feb 19, 2017
* refactor test-common.js so that global leak detection does not need to
  be disabled
* add test for common.fail()

PR-URL: #11433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 19, 2017

Landed in 7b76f82

@jasnell jasnell closed this Feb 19, 2017
addaleax pushed a commit that referenced this pull request Feb 22, 2017
* refactor test-common.js so that global leak detection does not need to
  be disabled
* add test for common.fail()

PR-URL: #11433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

This would need a backport PR to land in v6 or v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants