-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test, url: URLSearchParams splits across lines #11428
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The member methods of URLSearchParams should split across multiple lines with `util.inspect` depending on an option `breakLength`.
jasnell
approved these changes
Feb 16, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
mscdex
added
the
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
label
Feb 16, 2017
TimothyGu
approved these changes
Feb 17, 2017
joyeecheung
approved these changes
Feb 17, 2017
targos
approved these changes
Feb 17, 2017
targos
pushed a commit
to targos/node
that referenced
this pull request
Feb 18, 2017
The member methods of URLSearchParams should split across multiple lines with `util.inspect` depending on an option `breakLength`. PR-URL: nodejs#11428 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Landed in 8629b33 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 25, 2017
The member methods of URLSearchParams should split across multiple lines with `util.inspect` depending on an option `breakLength`. PR-URL: nodejs#11428 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This was referenced Nov 29, 2023
This was referenced Dec 10, 2023
This was referenced Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
test
Issues and PRs related to the tests.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The member methods of URLSearchParams should split across multiple lines with
util.inspect
depending on an optionbreakLength
.This test increases the coverage of internal/url.js:
The following line will be called:
node/lib/internal/url.js
Lines 1057 to 1059 in 82ddf96
Checklist
make -j4 test
(UNIX) passesAffected core subsystem(s)
test,url