Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: v7.x - #11122 - test: increase coverage of buffer #11312

Closed
wants to merge 1 commit into from
Closed

backport: v7.x - #11122 - test: increase coverage of buffer #11312

wants to merge 1 commit into from

Conversation

DavidCai1111
Copy link
Member

Backport of #11122 to v7.x.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v7.x labels Feb 11, 2017
@hiroppy hiroppy added the buffer Issues and PRs related to the buffer subsystem. label Feb 11, 2017
italoacasas
italoacasas approved these changes Feb 12, 2017
View reviewed changes
Copy link
Contributor

@italoacasas italoacasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@italoacasas
Copy link
Contributor

@DavidCai1993 can you rebase again, please.

@DavidCai1111
Copy link
Member Author

@italoacasas Done, PTAL.

italoacasas pushed a commit that referenced this pull request Feb 16, 2017
@DavidCai1111 @italoacasas
test: increase coverage of buffer
f542c59 
PR-URL: #11312
Backport-of: #11122
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@italoacasas
Copy link
Contributor

Landed f542c59. Thanks for the backport.

italoacasas pushed a commit that referenced this pull request Feb 22, 2017
@DavidCai1111 @italoacasas
test: increase coverage of buffer
66081d1 
PR-URL: #11312
Backport-of: #11122
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

needs a backport pr if it should land on v4 or v6

@gibfahn gibfahn mentioned this pull request Jun 17, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italoacasas italoacasas italoacasas approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DavidCai1111 @italoacasas @jasnell @thefourtheye @hiroppy @nodejs-github-bot